Skip to content

Refactor and update existing base BLAS packages according to current project conventions #788

Closed

Description

BLAS Updates

Refactor and clean-up existing base BLAS packages according to current project conventions.

Existing base BLAS packages need to be updated according to current project conventions before we can continue building out additional BLAS functionality. What follows is a general list of necessary changes, along with a list of packages which should be updated.

An example commit implementing (most of) these changes can be found in d66d80c (saxpy).

Updates

  1. replace nullptr with NULL
  2. remove namespace (and anything else C++) and use static functions
  3. rename file from addon.cpp to addon.c
  4. update include.gypi to reference addon.c file
  5. use argv macros for handling add-on callback arguments
  6. update benchmarks to use utility functions for generating arrays of random numbers, rather than explicit loops
  7. change "destination array" and "returns y" to "output array" and "returns output array" respectively
  8. change "deep equal" to "returns expected value"
  9. remove use of floor
  10. README and repl.txt copy edits
  11. in *.native.js files, use utilities for creating offset views, rather than explicit typed array creation
  12. update manifest.json file to include argv utility dependencies
  13. update manifest.json to use space indentation to match other project JSON files
  14. update manifest.json to include separate build configurations for compiling the addon, the benchmarks, and the examples.

Packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    BLASIssue or pull request related to Basic Linear Algebra Subprograms (BLAS).Native AddonsIssue involves or relates to Node.js native add-ons.Tracking IssueTracking issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions