Closed
Description
openedon Dec 31, 2022
BLAS Updates
Refactor and clean-up existing base BLAS packages according to current project conventions.
Existing base BLAS packages need to be updated according to current project conventions before we can continue building out additional BLAS functionality. What follows is a general list of necessary changes, along with a list of packages which should be updated.
An example commit implementing (most of) these changes can be found in d66d80c (saxpy
).
Updates
- replace
nullptr
withNULL
- remove namespace (and anything else C++) and use
static
functions - rename file from
addon.cpp
toaddon.c
- update include.gypi to reference
addon.c
file - use argv macros for handling add-on callback arguments
- update benchmarks to use utility functions for generating arrays of random numbers, rather than explicit loops
- change "destination array" and "returns y" to "output array" and "returns output array" respectively
- change "deep equal" to "returns expected value"
- remove use of
floor
- README and repl.txt copy edits
- in
*.native.js
files, use utilities for creating offset views, rather than explicit typed array creation - update
manifest.json
file to includeargv
utility dependencies - update
manifest.json
to use space indentation to match other project JSON files - update
manifest.json
to include separate build configurations for compiling the addon, the benchmarks, and the examples.
Packages
- ccopy
- cswap
- dasum
- daxpy
- dcopy
- ddot
- dnrm2
- dscal
- dsdot
- dswap
- sasum
- saxpy
- scopy ( Refactor
@stdlib/blas/base/scopy
#797 ) - sdot ( refactor: update add-on, examples, benchmarks, and docs #798 )
- sdsdot ( refactor: update add-on, examples, benchmarks, and docs #799 )
- snrm2 ( refactor: update add-on, benchmarks, tests, and examples #800 )
- sscal
- sswap ( Refactor
@stdlib/blas/base/sswap
#794 )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment