math: Updated atanh implementation based on FreeBSD for improved accuracy and efficiency#2746
Closed
Deepakchowdavarapu wants to merge 3 commits into
Closed
math: Updated atanh implementation based on FreeBSD for improved accuracy and efficiency#2746Deepakchowdavarapu wants to merge 3 commits into
Deepakchowdavarapu wants to merge 3 commits into
Conversation
Contributor
|
Hello! Thank you for your contribution to stdlib. We noticed that the contributing guidelines acknowledgment is missing from your pull request. Here's what you need to do:
This acknowledgment confirms that you've read the guidelines, which include:
We can't review or accept contributions without this acknowledgment. Thank you for your understanding and cooperation. We look forward to reviewing your contribution! |
3 tasks
Member
|
@Deepakchowdavarapu This PR cannot be merged as is.
As such, I will be closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
math: Update atanh implementation based on FreeBSD for improved accuracy and efficiency
This pull request updates the hyperbolic arctangent (atanh) function in the math/base/special module. The changes are inspired by the FreeBSD implementation, aiming to improve accuracy and efficiency.
Key changes:
The updated function maintains the existing API while providing more reliable results across a wider range of inputs. Performance impact is expected to be minimal, with potential improvements for certain input ranges.
Implementation details:
Testing:
This update addresses the concerns raised in issue #2089 and should provide a more robust implementation of the atanh function for stdlib users.
I welcome any feedback or suggestions for further improvements.