Skip to content

refactor: update blas/ext/base/sapxsumpw #1962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2024
Merged

refactor: update blas/ext/base/sapxsumpw #1962

merged 1 commit into from
Mar 23, 2024

Conversation

rxbryan
Copy link
Contributor

@rxbryan rxbryan commented Mar 20, 2024

Description

updates blas/ext/base/sapxsumpw to follow current project conventions

Related Issues

Does this pull request have any related issues?
#788
#1152.

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 20, 2024
@kgryte kgryte added Enhancement Issue or pull request for enhancing existing functionality. Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 20, 2024
@rxbryan rxbryan force-pushed the refactor-sapxsumpw branch from 3c4dcf8 to ef69959 Compare March 20, 2024 03:06
@rxbryan rxbryan changed the title refactor: update blas/ext/base/sapxsumpw refactor: update blas/ext/base/sapxsumpw Mar 20, 2024
@Planeshifter Planeshifter self-requested a review March 21, 2024 02:24
@rxbryan
refactor: update blas/ext/base/sapxsumpw
025091b 
updates blas/ext/base/sapxsumpw to follow current project conventions

Fixes: stdlib-js#1514
@rxbryan rxbryan force-pushed the refactor-sapxsumpw branch from ef69959 to 025091b Compare March 21, 2024 10:59
Planeshifter
Planeshifter approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @rxbryan. Will merge shortly.

@Planeshifter Planeshifter added Ready To Merge A pull request which is ready to be merged. and removed Needs Review A pull request which needs code review. labels Mar 23, 2024
@Planeshifter Planeshifter merged commit 30b95a8 into stdlib-js:develop Mar 23, 2024
@rxbryan rxbryan mentioned this pull request Mar 26, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/sapxsumpw to follow current project conventions
4 participants
@rxbryan @Planeshifter @kgryte @stdlib-bot