refactor: update blas/ext/base/dcusum to follow current project conventions
#1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Pranavchiku, can you review the PR? |
kgryte
added
Enhancement
kgryte
reviewed
Mar 14, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 14, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 14, 2024
lib/node_modules/@stdlib/blas/ext/base/dcusum/examples/index.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
requested changes
Mar 14, 2024
There was a problem hiding this comment.
Thanks @AuenKr for working on this, and thank you for being diligent and paying attention to detail on this. Really makes things easy on reviewers.
I think the only thing which needs to be updated is the manifest.json file. For an example, see https://github.com/stdlib-js/stdlib/blob/dc84fce54ee45d590860af4eb36845981342671f/lib/node_modules/%40stdlib/blas/ext/base/dfill/manifest.json. In short, we need to add specific build configurations for the addon vs benchmarks vs examples.
kgryte
added
the
Needs Changes
1 task
|
@kgryte, applied changes in |
stdlib-bot
added
the
BLAS
1 task
kgryte
reviewed
Mar 19, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
reviewed
Mar 19, 2024
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
approved these changes
Mar 19, 2024
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1471.
Description
This pull request:
@stdlib/blas/ext/base/dcusumto follow current projects conventionRelated Issues
This pull request:
blas/ext/base/dcusumto follow current project conventions #1471Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers