Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update blas/ext/base/dnansum to follow current project conventions #1899

Merged
merged 4 commits into from
Mar 17, 2024
Merged

refactor: update blas/ext/base/dnansum to follow current project conventions #1899

merged 4 commits into from
Mar 17, 2024

Conversation

AuenKr
Copy link
Contributor

@AuenKr AuenKr commented Mar 15, 2024

Resolves #1483.

Description

What is the purpose of this pull request?

This pull request:

  • refactored @stdlib/blas/ext/base/dnansum to follow current project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). label Mar 15, 2024
@Pranavchiku
chore: apply suggestions from code review
5f3791a 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
Pranavchiku reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested, rest all is good. Once addressed this will be good to merge.

@Pranavchiku Pranavchiku added Native Addons Issue involves or relates to Node.js native add-ons. Needs Changes Pull request which needs changes before being merged. labels Mar 15, 2024
Pranavchiku
Pranavchiku approved these changes Mar 16, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @AuenKr !

@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 16, 2024
@Planeshifter Planeshifter merged commit 9dce525 into stdlib-js:develop Mar 17, 2024
8 checks passed
@AuenKr AuenKr mentioned this pull request Mar 26, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Native Addons Issue involves or relates to Node.js native add-ons. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/dnansum to follow current project conventions
4 participants
@AuenKr @Pranavchiku @Planeshifter @stdlib-bot