-
-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add native C implementation for acsc #1439
Conversation
Signed-off-by: utkarsh_raj <49344502+rajutkarsh07@users.noreply.github.com>
@Planeshifter @kgryte @Pranavchiku please review this |
I’ll review it in a while |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of files missing, please refer #1429 and proceed.
@Pranavchiku You already opened a PR for this: #1298 |
@Pranavchiku I think this PR should be closed in favor of your previous PR which only needs a few small changes to get over the finish line. |
@kgryte I will complete PR submitted by @Pranavchiku with the required changes |
@rajutkarsh07 You'd need commit access to his PR and make the changes, which I don't think you have. I think it is probably better if @Pranavchiku finishes that PR and you work on a separate issue. |
I'm going to close this in favor of #1298. |
Resolves #859
Description
This pull request:
Related Issues
This pull request:
@stdlib/math/base/special/acsc
#859Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers