Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add native C implementation for acsc #1439

Closed

Conversation

rajutkarsh07
Copy link
Contributor

Resolves #859

Description

What is the purpose of this pull request?

This pull request:

  • Add native C implementation for acsc.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Signed-off-by: utkarsh_raj <49344502+rajutkarsh07@users.noreply.github.com>
@rajutkarsh07
Copy link
Contributor Author

@Planeshifter @kgryte @Pranavchiku please review this

@Pranavchiku
Copy link
Member

I’ll review it in a while

Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of files missing, please refer #1429 and proceed.

@Pranavchiku Pranavchiku added the Needs Changes Pull request which needs changes before being merged. label Mar 2, 2024
@kgryte
Copy link
Member

kgryte commented Mar 3, 2024

@Pranavchiku You already opened a PR for this: #1298

@kgryte
Copy link
Member

kgryte commented Mar 3, 2024

@Pranavchiku I think this PR should be closed in favor of your previous PR which only needs a few small changes to get over the finish line.

@kgryte kgryte added the Duplicate This issue or pull request already exists. label Mar 3, 2024
@rajutkarsh07
Copy link
Contributor Author

rajutkarsh07 commented Mar 3, 2024

@kgryte I will complete PR submitted by @Pranavchiku with the required changes

@kgryte
Copy link
Member

kgryte commented Mar 3, 2024

@rajutkarsh07 You'd need commit access to his PR and make the changes, which I don't think you have. I think it is probably better if @Pranavchiku finishes that PR and you work on a separate issue.

@Planeshifter Planeshifter changed the title feat: Add native C implementation for acsc feat: add native C implementation for acsc Mar 8, 2024
@kgryte
Copy link
Member

kgryte commented Mar 17, 2024

I'm going to close this in favor of #1298.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate This issue or pull request already exists. Needs Changes Pull request which needs changes before being merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/acsc
3 participants