Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C implementation for @stdlib/math/base/special/acoversin #1429

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Add C implementation for @stdlib/math/base/special/acoversin #1429

merged 2 commits into from
Mar 1, 2024

Conversation

aman-095
Copy link
Member

@aman-095 aman-095 commented Mar 1, 2024

Resolves #776.

Description

What is the purpose of this pull request?

This pull request adds native C implementation for
@stdlib/math/base/special/acoversin

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

Pranavchiku
Pranavchiku requested changes Mar 1, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work! Left few comments, apply those and this PR will be good to merge.

lib/node_modules/@stdlib/math/base/special/acoversin/lib/native.js Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/acoversin/manifest.json Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/special/acoversin/test/test.native.js Outdated Show resolved Hide resolved
@Pranavchiku Pranavchiku added the Needs Changes Pull request which needs changes before being merged. label Mar 1, 2024
Pranavchiku
Pranavchiku approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks good to me.

@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 1, 2024
@Planeshifter Planeshifter merged commit 1096686 into stdlib-js:develop Mar 1, 2024
7 checks passed
@Pranavchiku Pranavchiku mentioned this pull request Mar 2, 2024
Closed
1 task
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. C Issue involves or relates to C. labels Mar 3, 2024
kgryte
kgryte reviewed Mar 3, 2024
View reviewed changes
lib/node_modules/@stdlib/math/base/special/acoversin/manifest.json
]
}
]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Planeshifter This is probably another thing we can automate. Ensuring trailing newlines for most file types.

@aman-095 aman-095 mentioned this pull request Apr 1, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/acoversin
4 participants
@aman-095 @kgryte @Pranavchiku @Planeshifter