Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : add complex/base/parse #1385

Merged
merged 12 commits into from
Feb 26, 2024
Merged

feat : add complex/base/parse #1385

merged 12 commits into from
Feb 26, 2024

Conversation

marsian83
Copy link
Contributor

Description

This PR tackles the parsing as discussed here

This implements a parser which will convert a complex number represented as a string to a complex like object

This can be used as a base for @stdlib/complex/assert/is-complex and @stdlib/complex/parse-32 and @stdlib/complex/parse-64.
Detailed discussion as to why this approach may be chosen can be found #1332 & #1370

Related Issues

#1332
#1333
#1370

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

@marsian83 marsian83 changed the title feat : add @stdlib/assert/is-nonnegative-finite feat : add @stdlib/complex/base/parse Feb 25, 2024
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review. Utilities Issue or pull request concerning general utilities. labels Feb 25, 2024
@kgryte kgryte changed the title feat : add @stdlib/complex/base/parse feat : add complex/base/parse Feb 25, 2024
@kgryte
Copy link
Member

kgryte commented Feb 25, 2024

@marsian83 Looks like linting is failing. Mind resolving those lint errors?

@marsian83
Copy link
Contributor Author

@marsian83 Looks like linting is failing. Mind resolving those lint errors?

While linting this line is behaving weirdly
image

It requires me to have no spaces in JSDOC type definitions but also requires me to have spaces after the curly bracket opening and before it closing. how do I resolve this conflicting requirement

@marsian83
Copy link
Contributor Author

marsian83 commented Feb 26, 2024

image

These three are proving to be quite problematic to me, the first one, I do not understand.
The second is the one I discussed above.
The third one is asking me to require Number which is an inbuilt JS module?

Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Spandan Barve <114365550+marsian83@users.noreply.github.com>
@marsian83
Copy link
Contributor Author

I have noted and understood the changes you made and also commited and signed them off
I am still confused about the linter asking me to require 'Number' though

@marsian83
Copy link
Contributor Author

There was a slight lint error in the license headers. I have fixed and pushed changes

marsian83 and others added 3 commits February 26, 2024 09:51
Parses -> Parse
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter
Copy link
Member

@marsian83 Thanks for making the requested changes and working on this new package in the first place! Made some further small changes to align with project conventions and will merge once CI passes. 🚀

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@marsian83
Copy link
Contributor Author

@Planeshifter Thanks 😄 for bringing to my attention the conventions I missed, I will keep these in mind from next time on now that you have pointed these out.

Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Planeshifter merged commit 4c6159f into stdlib-js:develop Feb 26, 2024
7 checks passed
@Planeshifter Planeshifter removed the Needs Review A pull request which needs code review. label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Issue or pull request for adding a new feature. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants