-
-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat : add complex/base/parse
#1385
Conversation
complex/base/parse
@marsian83 Looks like linting is failing. Mind resolving those lint errors? |
While linting this line is behaving weirdly It requires me to have no spaces in JSDOC type definitions but also requires me to have spaces after the curly bracket opening and before it closing. how do I resolve this conflicting requirement |
Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Spandan Barve <114365550+marsian83@users.noreply.github.com>
I have noted and understood the changes you made and also commited and signed them off |
There was a slight lint error in the license headers. I have fixed and pushed changes |
Parses -> Parse
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@marsian83 Thanks for making the requested changes and working on this new package in the first place! Made some further small changes to align with project conventions and will merge once CI passes. 🚀 |
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
@Planeshifter Thanks 😄 for bringing to my attention the conventions I missed, I will keep these in mind from next time on now that you have pointed these out. |
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Description
This PR tackles the parsing as discussed here
This implements a parser which will convert a complex number represented as a string to a complex like object
This can be used as a base for
@stdlib/complex/assert/is-complex
and@stdlib/complex/parse-32
and@stdlib/complex/parse-64
.Detailed discussion as to why this approach may be chosen can be found #1332 & #1370
Related Issues
#1332
#1333
#1370
Checklist
@stdlib-js/reviewers