Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: add @stdlib/complex/parse-float64 #1333

Closed
3 tasks done
kgryte opened this issue Feb 21, 2024 · 9 comments · Fixed by #1362
Closed
3 tasks done

[RFC]: add @stdlib/complex/parse-float64 #1333

kgryte opened this issue Feb 21, 2024 · 9 comments · Fixed by #1362
Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.

Comments

@kgryte
Copy link
Member

kgryte commented Feb 21, 2024

Description

This RFC proposes adding the package @stdlib/complex/parse-float64.

The package should be similar in structure to @stdlib/complex/reviver-float64.

The goal is to parse a complex number string (e.g., 1 + 8j) and return a Complex128 instance.

function parseComplex128( str ) { ... }

Package: @stdlib/complex/parse-float64
Alias: parseComplex128

Related Issues

Related issues #1332

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@kgryte kgryte added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! labels Feb 21, 2024
@dainik10

This comment was marked as outdated.

Sign in to view
@kgryte

This comment was marked as outdated.

Sign in to view
@gunjjoshi

This comment was marked as outdated.

Sign in to view
@kgryte

This comment was marked as outdated.

Sign in to view
@kgryte kgryte added priority: Low Low priority concern or feature request. Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Utilities Issue or pull request concerning general utilities. JavaScript Issue involves or relates to JavaScript. labels Feb 23, 2024
@Pranavbj
Copy link

Pranavbj commented Feb 23, 2024 •
edited
Loading

hey @kgryte , I have understood this issue and I would like to work on this issue. Please assign this issue to me.

@marsian83
Copy link
Contributor

Hi, since I have been assigned #1333 which is similar in structure to this, can I be assigned this issue as well.
I would love to work on them together as they have similar structure,

@Snehil-Shah Snehil-Shah mentioned this issue Feb 24, 2024
Merged
1 task
@Pranavchiku
Copy link
Member

@marsian83 I will suggest you to fix one issue at a time. I appreciate your interest, and encourage you to pick issues of varied nature that will help you understand vast portion of codebase.

This was referenced Feb 24, 2024
Open
Merged
@guruharsha1
Copy link

@kgryte can you please assign this issue to me?

@kgryte
Copy link
Member Author

kgryte commented Feb 25, 2024

@guruharsha1 This is already being worked on in other PRs, so I suggest picking up another good first issue.

Planeshifter added a commit that referenced this issue Feb 28, 2024
@Snehil-Shah @Pranavchiku
@kgryte @Planeshifter
feat: add complex/parse-float64
1154a11 
PR-URL: #1362 
Closes: #1333 

Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Co-authored-by: Athan Reines <kgryte@gmail.com>
Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com>
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> 
Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted RFC feature request which has been accepted. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. priority: Low Low priority concern or feature request. RFC Request for comments. Feature requests and proposed changes. Utilities Issue or pull request concerning general utilities.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add complex/parse-float64 Snehil-Shah/stdlib
7 participants
@kgryte @gunjjoshi @guruharsha1 @Pranavchiku @dainik10 @Pranavbj @marsian83