Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: refactor blas/ext/base/snansumkbn2 to follow current project conventions #1530

Open
3 tasks done
Planeshifter opened this issue Mar 3, 2024 · 3 comments
Open
3 tasks done

[RFC]: refactor blas/ext/base/snansumkbn2 to follow current project conventions #1530

Planeshifter opened this issue Mar 3, 2024 · 3 comments
Assignees
@Tushar98644
Labels
Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.

Comments

@Planeshifter
Copy link
Member

Description

This RFC proposes refactoring @stdlib/blas/ext/base/snansumkbn2 to follow current project conventions.

These conventions are outlined in more detail in #788. Namely, we want to migrate from C++ add-on interfaces to C add-on interfaces and then make various style and simplification changes.

Some example commits which perform most, if not all, of the requested changes include d66d80c (saxpy), 3c82fe7 (cswap), and 5b15c96 (dasum).

Related Issues

Related issues #788, #1152.

Questions

No.

Other

No.

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Planeshifter Planeshifter added Good First Issue A good first issue for new contributors! Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request. JavaScript Issue involves or relates to JavaScript. labels Mar 3, 2024
@Tushar98644
Copy link

@Planeshifter Can i take up the issue ?

@Planeshifter
Copy link
Member Author

Sure! Thanks for taking this on!

@vr-varad
Copy link
Contributor

vr-varad commented Apr 7, 2024

@Planeshifter @kgryte as this refactoring is related to my last few issues, would you mind if I work on this if no one is working on this?

@vr-varad vr-varad mentioned this issue Apr 7, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tushar98644 Tushar98644

Labels
Good First Issue A good first issue for new contributors! JavaScript Issue involves or relates to JavaScript. Native Addons Issue involves or relates to Node.js native add-ons. priority: High High priority concern or feature request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: update blas/ext/base/snansumkbn to follow current project conventions vr-varad/stdlib
3 participants
@Planeshifter @Tushar98644 @vr-varad