Update sending transaction end point (#21480) #21541
Conversation
Jenkins BuildsClick to see older builds (31)
|
alwx
force-pushed
the
update-sending-transactions-endpoint
branch
from
c2051ca
to
0d03673
Compare
alwx
force-pushed
the
update-sending-transactions-endpoint
branch
from
1a5e40a
to
78f1308
Compare
alwx
changed the title
alwx
changed the title
|
This one is now ready to be reviewed. |
| (defn signature-rsv | ||
| [signature] | ||
| {:r (subs signature 0 64) | ||
| :s (subs signature 64 128) | ||
| :v (subs signature 128 130)}) |
There was a problem hiding this comment.
Duplicated functions here?
https://github.com/status-im/status-mobile/pull/21589/files#r1831380457
There was a problem hiding this comment.
Oh, I see you are removing that file in this PR. Better to coordinate with @clauxx the path forward for this so we don't waste QA time testing the same code twice (also solving rebase conflicts better).
As I mentioned in Cristian's PR, would love to see some unit tests for this function, so it can serve as documentation for this sensible wallet code.
There was a problem hiding this comment.
Nope. I removed that one.
This one is fixed + it returns only the signature, and not the vector containing the tx-hash (which is kinda dumb in the original one).
There was a problem hiding this comment.
that PR was already QA'd, so I'll just merge it since this PR might take longer to merge. Conflict-wise shouldn't make much of a difference
|
@alwx UPDATE: your PR does not fix #21555. Most likely your branch was outdated when I checked, that's why I didn't reproduce. But I am reproducing now in the latest rebased build. Issue should be fixed by status-im/status-go#6059 |
alwx
changed the title
|
@alwx - Can you help me update this PR to point to status-im/status-go#6059 PR ( It requires the new send flow #21600 (comment) |
Fixes #21480
Basically utilizes the new transaction flow implemented on the go side:
wallet_CreateMultiTransactionandwallet_ProceedWithTransactionsSignaturesare now deprecated and not used anymore.wallet.sign.transactionssignal is deprecated and not used either.The new transaction flow looks like this:
wallet_BuildTransactionsFromRoutewallet.router.sign-transactionssignalwallet_SignMessagecall or sign on keycardwallet_SendRouterTransactionsWithSignatureswith the signatures of signed hashes from the previous stepwallet.router.transactions-sentsignal will be sent after sending transactions or an error occursPlatforms
Areas that maybe impacted
Functional