Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet)_: broken swap and bridge for erc20 tokens fixed #6059

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

saledjenic
Copy link
Contributor

@saledjenic saledjenic commented Nov 7, 2024

Fixes status-im/status-mobile#21555

This change fixes Bridge and Swap txs for erc20 tokens that broke after adding Amount parameter to the key composition, to increase uniqness, for storing data internally.

@status-im-auto
Copy link
Member

status-im-auto commented Nov 7, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 4e5cf50 #1 2024-11-07 13:24:07 ~4 min ios 📦zip
✔️ 4e5cf50 #1 2024-11-07 13:24:14 ~4 min windows 📦zip
✔️ 4e5cf50 #1 2024-11-07 13:24:21 ~4 min tests-rpc 📄log
✔️ 4e5cf50 #1 2024-11-07 13:24:28 ~4 min macos 📦zip
✔️ 4e5cf50 #1 2024-11-07 13:25:06 ~5 min macos 📦zip
✔️ 4e5cf50 #1 2024-11-07 13:25:09 ~5 min linux 📦zip
✔️ 4e5cf50 #1 2024-11-07 13:25:50 ~6 min android 📦aar
✔️ 4e5cf50 #1 2024-11-07 13:54:48 ~34 min tests 📄log
✔️ 758c477 #2 2024-11-07 13:27:20 ~3 min windows 📦zip
✔️ 758c477 #2 2024-11-07 13:28:32 ~4 min ios 📦zip
✔️ 758c477 #2 2024-11-07 13:28:33 ~4 min tests-rpc 📄log
✔️ 758c477 #2 2024-11-07 13:29:08 ~4 min macos 📦zip
✔️ 758c477 #2 2024-11-07 13:30:27 ~5 min linux 📦zip
✔️ 758c477 #2 2024-11-07 13:30:43 ~5 min macos 📦zip
✔️ 758c477 #2 2024-11-07 13:32:04 ~6 min android 📦aar
✔️ 758c477 #2 2024-11-07 14:28:37 ~33 min tests 📄log

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 60.80%. Comparing base (f15c64c) to head (758c477).

Files with missing lines Patch % Lines
...et/router/pathprocessor/processor_swap_paraswap.go 0.00% 2 Missing ⚠️
...allet/router/pathprocessor/processor_bridge_hop.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6059      +/-   ##
===========================================
- Coverage    60.87%   60.80%   -0.08%     
===========================================
  Files          811      811              
  Lines       108894   108895       +1     
===========================================
- Hits         66293    66211      -82     
- Misses       34843    34907      +64     
- Partials      7758     7777      +19     
Flag Coverage Δ
functional 13.08% <25.00%> (-0.01%) ⬇️
unit 60.16% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...vices/wallet/transfer/transaction_manager_route.go 41.87% <100.00%> (+0.28%) ⬆️
transactions/types.go 30.00% <ø> (ø)
...allet/router/pathprocessor/processor_bridge_hop.go 11.66% <0.00%> (ø)
...et/router/pathprocessor/processor_swap_paraswap.go 48.20% <0.00%> (ø)

... and 33 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERC20 bridge and swap transactions are broken
6 participants