-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wallet)_: broken swap and bridge for erc20 tokens fixed #6059
Open
saledjenic
wants to merge
1
commit into
develop
Choose a base branch
from
fix/swap-bridge-sending
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saledjenic
requested review from
alaibe,
shivekkhurana,
dlipicar and
smohamedjavid
November 7, 2024 13:19
saledjenic
force-pushed
the
fix/swap-bridge-sending
branch
from
November 7, 2024 13:23
4e5cf50
to
758c477
Compare
Jenkins Builds
|
alaibe
approved these changes
Nov 7, 2024
dlipicar
approved these changes
Nov 7, 2024
This was referenced Nov 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6059 +/- ##
===========================================
- Coverage 60.87% 60.80% -0.08%
===========================================
Files 811 811
Lines 108894 108895 +1
===========================================
- Hits 66293 66211 -82
- Misses 34843 34907 +64
- Partials 7758 7777 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
|
smohamedjavid
approved these changes
Nov 7, 2024
briansztamfater
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes status-im/status-mobile#21555
This change fixes Bridge and Swap txs for erc20 tokens that broke after adding
Amount
parameter to the key composition, to increase uniqness, for storing data internally.