Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check permissions even if there's an inflight request #19439

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Check permissions even if there's an inflight request #19439

merged 1 commit into from
Mar 28, 2024

Conversation

cammellos
Copy link
Contributor

@cammellos cammellos commented Mar 28, 2024 •
edited by pavloburykh
Loading

Fixes #19407
We should always send a request, even if there's one in flight, in theory, we should ignore the result of the one in flight (in case their response comes out of order, that's still possible after this PR, though I haven't experienced it).

This should mitigate the issue for the time being, and I can look at ignoring previous requests next.

@cammellos cammellos self-assigned this Mar 28, 2024
@status-im-auto
Copy link
Member

status-im-auto commented Mar 28, 2024 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ f1193b5 #1 2024-03-28 14:11:30 ~2 min tests 📄log
✔️ f1193b5 #1 2024-03-28 14:16:20 ~7 min android-e2e 🤖apk 📲
✔️ f1193b5 #1 2024-03-28 14:16:31 ~7 min android 🤖apk 📲
❌ dcc4f01 #2 2024-03-28 14:18:41 ~2 min tests 📄log
✔️ dcc4f01 #2 2024-03-28 14:23:45 ~7 min android-e2e 🤖apk 📲
✔️ dcc4f01 #2 2024-03-28 14:23:50 ~7 min android 🤖apk 📲
✔️ dcc4f01 #2 2024-03-28 14:26:13 ~9 min ios 📱ipa 📲

@pavloburykh pavloburykh self-assigned this Mar 28, 2024
@cammellos cammellos force-pushed the bug/disable-checking-on-flight branch from f1193b5 to dcc4f01 Compare March 28, 2024 14:16
@status-im-auto
Copy link
Member

94% of end-end tests have passed

Total executed tests: 48
Failed tests: 2
Expected to fail tests: 1
Passed tests: 45

IDs of failed tests: 702936,702947 

IDs of expected to fail tests: 703503

Failed tests (2)

Click to expand
  • Rerun failed tests

    • Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936

    Device 2: Joining community
    Device 2: Looking for a message by text: https://status.app/c/ 

    Test setup failed: activity_center/test_activity_center.py:282: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:419: in join_community
    ChatView(self.driver).chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body()
../views/chat_view.py:175: in click_on_link_inside_message_body
    self.message_body.wait_for_visibility_of_element(30)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` is not found on the screen after wait_for_visibility_of_element



    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947 

    Test setup failed: activity_center/test_activity_center.py:282: in prepare_devices
    self.community_2.join_community()
../views/chat_view.py:419: in join_community
    ChatView(self.driver).chat_element_by_text("https://status.app/c/").click_on_link_inside_message_body()
../views/chat_view.py:175: in click_on_link_inside_message_body
    self.message_body.wait_for_visibility_of_element(30)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: Text by xpath:`//android.view.ViewGroup[@content-desc='chat-item']//android.widget.TextView[contains(@text,'https://status.app/c/')]` is not found on the screen after wait_for_visibility_of_element



    Expected to fail tests (1)

    Click to expand

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (45)

    Click to expand

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_mute_chat, id: 703495
    Device sessions

    3. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    4. test_group_chat_reactions, id: 703202
    Device sessions

    5. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    6. test_group_chat_offline_pn, id: 702808
    Device sessions

    @pavloburykh
    Copy link
    Contributor

    @cammellos thank you for the fix. PR is ready for merge and cherrypick.

    @cammellos cammellos force-pushed the bug/disable-checking-on-flight branch from dcc4f01 to ed824bd Compare March 28, 2024 17:08
    @cammellos cammellos merged commit ed824bd into develop Mar 28, 2024
    2 checks passed
    @cammellos cammellos deleted the bug/disable-checking-on-flight branch March 28, 2024 17:08
    @pavloburykh pavloburykh mentioned this pull request Apr 15, 2024
    Closed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jo-mut jo-mut jo-mut approved these changes

    @Parveshdhull Parveshdhull Parveshdhull approved these changes

    @codemaster115 codemaster115 Awaiting requested review from codemaster115

    Assignees

    @cammellos cammellos

    @pavloburykh pavloburykh

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
    Archived in project
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Role is not updated correctly if user unselects several accounts with required tokens one by one
    5 participants
    @cammellos @status-im-auto @pavloburykh @Parveshdhull @jo-mut