Check permissions even if there's an inflight request

Author: cammellos

src/status_im/contexts/communities/actions/addresses_for_permissions/events.cljs

@@ -79,15 +79,14 @@
     ;; incorrect highest permission role.
     {:db (update db :communities/permissions-checks-for-selection dissoc community-id)}
     (let [{:keys [checking?]} (get-in db [:communities/permissions-checks-for-selection community-id])]
-      (when-not checking?
         {:db (assoc-in db [:communities/permissions-checks-for-selection community-id :checking?] true)
          :fx [[:json-rpc/call
                [{:method     :wakuext_checkPermissionsToJoinCommunity
                  :params     [{:communityId community-id :addresses addresses}]
                  :on-success [:communities/check-permissions-to-join-during-selection-success
                               community-id]
                  :on-error   [:communities/check-permissions-to-join-during-selection-failure
-                              community-id addresses]}]]]}))))
+                              community-id addresses]}]]]})))
 
 ;; This event should be used to check permissions temporarily because it won't
 ;; mutate the state `:communities/permissions-check` (used by many other

src/status_im/contexts/communities/actions/addresses_for_permissions/events_test.cljs

@@ -103,11 +103,4 @@
                                  community-id]
                     :on-error   [:communities/check-permissions-to-join-during-selection-failure
                                  community-id addresses]}]]]}
-           (sut/check-permissions-to-join-for-selection cofx [community-id addresses])))))
-
-  (testing "when there are addresses to check permissions, but currently checking, then skip the check"
-    (let [addresses ["0xA"]
-          cofx      {:db {:communities/permissions-checks-for-selection
-                          {"other-comm-id" {}
-                           community-id    {:checking? true}}}}]
-      (is (nil? (sut/check-permissions-to-join-for-selection cofx [community-id addresses]))))))
+           (sut/check-permissions-to-join-for-selection cofx [community-id addresses]))))))