Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: slide button #18922

Merged
merged 12 commits into from
Mar 5, 2024
Merged

Fix: slide button #18922

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5778757
fix slide button
OmarBasem Feb 21, 2024
23be8a2
review
OmarBasem Feb 21, 2024
ae26609
lint
OmarBasem Feb 21, 2024
7ec2a20
lint
OmarBasem Feb 21, 2024
7e18faf
lint
OmarBasem Feb 29, 2024
74a4eb8
lint
OmarBasem Feb 29, 2024
c455094
lint
OmarBasem Feb 29, 2024
557cc02
lint
OmarBasem Mar 1, 2024
628b78e
lint
OmarBasem Mar 1, 2024
47c704d
qa
OmarBasem Mar 4, 2024
0fc6e3f
review
OmarBasem Mar 4, 2024
62eafef
lint
OmarBasem Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
review
  • Loading branch information
@OmarBasem
OmarBasem committed Mar 5, 2024
commit 0fc6e3f99aa2af7312357e4ccf1e38122da5bb3e
13 changes: 3 additions & 10 deletions src/quo/components/buttons/slide_button/view.cljs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
[react-native.reanimated :as reanimated]))

(defn drag-gesture
[x-pos gestures-disabled? set-gestures-disabled disabled? track-width sliding-complete?
[x-pos disabled? track-width sliding-complete?
set-sliding-complete
on-complete reset-fn]
(let [gestures-enabled? (not (or disabled? gestures-disabled?))]
(let [gestures-enabled? (not disabled?)]
(-> (gesture/gesture-pan)
(gesture/with-test-ID :slide-button-gestures)
(gesture/enabled gestures-enabled?)
Expand All @@ -28,7 +28,6 @@
reached-end? (>= clamped-x track-width)]
(reanimated/set-shared-value x-pos clamped-x)
(when (and reached-end? (not sliding-complete?))
(set-gestures-disabled true)
(set-sliding-complete true)
(when on-complete (on-complete reset-fn))))))
(gesture/on-end (fn [event]
Expand All @@ -55,14 +54,11 @@
[track-width set-track-width] (rn/use-state nil)
[sliding-complete?
set-sliding-complete] (rn/use-state false)
[gestures-disabled?
set-gestures-disabled] (rn/use-state disabled?)
on-track-layout (rn/use-callback
#(set-track-width (oops/oget % "nativeEvent.layout.width")))
reset-fn (rn/use-callback
(fn []
(set-sliding-complete false)
(set-gestures-disabled false)
(animations/reset-track-position x-pos)))
dimensions (rn/use-callback
(partial utils/get-dimensions
Expand All @@ -77,16 +73,13 @@
[dimensions])
custom-color (if (= type :danger) :danger customization-color)
gesture (rn/use-memo #(drag-gesture x-pos
gestures-disabled?
set-gestures-disabled
disabled?
(dimensions :usable-track)
sliding-complete?
set-sliding-complete
on-complete
reset-fn)
[gestures-disabled? sliding-complete? disabled?])]
(rn/use-effect #(set-gestures-disabled disabled?) [disabled?])
[sliding-complete? disabled?])]
[gesture/gesture-detector
{:gesture gesture}
[reanimated/view
Expand Down