Fix: slide button #18922

OmarBasem · 2024-02-21T07:47:30Z

This PR fixes the disabled? prop for the slide button where the slide button wouldn't slide after changing disabled? from true to false

Parts affected:

Wallet account creation page. Demo below:

Screen_Recording_20240221_114329_Status.mp4

status-im-auto · 2024-02-21T07:49:55Z

Jenkins Builds

Click to see older builds (31)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`8c10e64`	#1	2024-02-21 07:49:55	~2 min	`tests`	📄`log`
✔️	`8c10e64`	#1	2024-02-21 07:54:38	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`8c10e64`	#1	2024-02-21 07:54:42	~6 min	`ios`	📱`ipa` 📲
✔️	`8c10e64`	#1	2024-02-21 07:55:13	~7 min	`android`	🤖`apk` 📲

❌	`7ba9700`	#2	2024-02-21 12:18:02	~3 min	`tests`	📄`log`

✔️	`b960b49`	#3	2024-02-21 12:25:50	~7 min	`android`	🤖`apk` 📲
✔️	`b960b49`	#3	2024-02-21 12:26:01	~7 min	`tests`	📄`log`
✔️	`b960b49`	#3	2024-02-21 12:26:08	~7 min	`ios`	📱`ipa` 📲
✔️	`b960b49`	#3	2024-02-21 12:27:15	~9 min	`android-e2e`	🤖`apk` 📲

✔️	`4746535`	#4	2024-02-26 07:55:37	~5 min	`tests`	📄`log`
✔️	`4746535`	#4	2024-02-26 07:56:38	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`4746535`	#4	2024-02-26 07:58:06	~7 min	`android`	🤖`apk` 📲
✔️	`4746535`	#4	2024-02-26 07:58:29	~8 min	`ios`	📱`ipa` 📲

✔️	`869aae2`	#5	2024-02-29 06:39:44	~6 min	`android`	🤖`apk` 📲
✔️	`869aae2`	#5	2024-02-29 06:40:21	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`869aae2`	#5	2024-02-29 06:44:07	~11 min	`ios`	📱`ipa` 📲
✔️	`869aae2`	#6	2024-02-29 08:17:50	~5 min	`tests`	📄`log`

✔️	`dde815d`	#7	2024-03-01 03:38:34	~6 min	`tests`	📄`log`
✔️	`dde815d`	#6	2024-03-01 03:39:36	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`dde815d`	#6	2024-03-01 03:40:47	~9 min	`android`	🤖`apk` 📲
✔️	`dde815d`	#6	2024-03-01 03:43:09	~11 min	`ios`	📱`ipa` 📲

✔️	`4d3a303`	#8	2024-03-01 05:31:40	~6 min	`android`	🤖`apk` 📲
✔️	`4d3a303`	#8	2024-03-01 05:31:51	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`4d3a303`	#8	2024-03-01 05:36:47	~11 min	`ios`	📱`ipa` 📲
✔️	`4d3a303`	#10	2024-03-01 07:40:43	~6 min	`tests`	📄`log`

✔️	`22166fd`	#9	2024-03-04 10:55:36	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`22166fd`	#9	2024-03-04 10:56:11	~6 min	`android`	🤖`apk` 📲
✔️	`22166fd`	#9	2024-03-04 11:00:12	~11 min	`ios`	📱`ipa` 📲

✔️	`a36ea56`	#13	2024-03-04 12:59:17	~5 min	`tests`	📄`log`
✔️	`a36ea56`	#11	2024-03-04 12:59:58	~6 min	`android`	🤖`apk` 📲
✔️	`a36ea56`	#11	2024-03-04 13:08:20	~14 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`c97be55`	#13	2024-03-04 13:41:37	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`c97be55`	#13	2024-03-04 13:41:45	~6 min	`android`	🤖`apk` 📲
✔️	`c97be55`	#13	2024-03-04 13:46:38	~11 min	`ios`	📱`ipa` 📲

✔️	`62eafef`	#14	2024-03-05 03:20:59	~6 min	`android`	🤖`apk` 📲
✔️	`62eafef`	#14	2024-03-05 03:21:39	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`62eafef`	#14	2024-03-05 03:22:12	~7 min	`ios`	📱`ipa` 📲
✔️	`62eafef`	#18	2024-03-05 03:44:00	~5 min	`tests`	📄`log`

src/quo/components/buttons/slide_button/view.cljs

J-Son89

nice one @OmarBasem.

Minor detail, as you have this shown in the video attached but the description should mention that this affects the create account page and should be tested there 👍

status-im-auto · 2024-02-21T14:34:51Z

90% of end-end tests have passed

Total executed tests: 48
Failed tests: 4
Expected to fail tests: 1
Passed tests: 43

IDs of failed tests: 702782,702957,703495,702958

IDs of expected to fail tests: 703503

Failed tests (4)

Click to expand

Rerun failed tests

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device 2: Find `Button` by `xpath`: `//[@content-desc='password-input']/../following-sibling:://*[@text='Join Community']` Device 2: Tap on found: Button Test setup failed: activity_center/test_activity_center.py:409: in prepare_devices self.community_2.join_community() ../views/chat_view.py:444: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Test setup failed: activity_center/test_activity_center.py:409: in prepare_devices self.community_2.join_community() ../views/chat_view.py:444: in join_community self.community_status_joined.wait_for_visibility_of_element(60) ../views/base_element.py:139: in wait_for_visibility_of_element raise TimeoutException( Device 2: Text by accessibility id:`status-tag-positive` is not found on the screen after wait_for_visibility_of_element

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782

Device 2: Find OpenInStatusButton by xpath: //*[@text="Open in Status"]
Device 2: Tap on found: OpenInStatusButton

critical/chats/test_1_1_public_chats.py:178: in test_1_1_chat_emoji_send_reply_and_open_link
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message with emoji was not sent or received in 1-1 chat
E    No reply received in 1-1 chat

Device sessions

Device 1:

Device 2:

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495

# STEP: Change device time so chat will be unmuted by timer
Device 2: Long press on ChatElement

critical/chats/test_group_chat.py:459: in test_group_chat_mute_chat
    chat.long_press_element()
../views/base_element.py:315: in long_press_element
    action.long_press(element).release().perform()
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/common/touch_action.py:174: in perform
    self._driver.execute(Command.TOUCH_ACTION, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:345: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:122: in check_response
    raise exception_class(msg=message, stacktrace=format_stacktrace(stacktrace))
 The element 'By.xpath: //*[@content-desc='author-primary-name'][starts-with(@text,'welfuvq')]/..' is not linked to the same object in DOM anymore; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#stale-element-reference-exception
E   Stacktrace:
E   io.appium.uiautomator2.common.exceptions.StaleElementReferenceException: The element 'By.xpath: //*[@content-desc='author-primary-name'][starts-with(@text,'welfuvq')]/..' is not linked to the same object in DOM anymore
E   	at io.appium.uiautomator2.model.ElementsCache.restore(ElementsCache.java:122)
E   	at io.appium.uiautomator2.model.ElementsCache.get(ElementsCache.java:153)
E   	at io.appium.uiautomator2.handler.Location.safeHandle(Location.java:23)
E   	at io.appium.uiautomator2.handler.request.SafeRequestHandler.handle(SafeRequestHandler.java:59)
E   	at io.appium.uiautomator2.server.AppiumServlet.handleRequest(AppiumServlet.java:277)
E   	at io.appium.uiautomator2.server.AppiumServlet.handleHttpRequest(AppiumServlet.java:271)
E   	at io.appium.uiautomator2.http.ServerHandler.channelRead(ServerHandler.java:68)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.handler.codec.MessageToMessageDecoder.channelRead(MessageToMessageDecoder.java:102)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.channel.CombinedChannelDuplexHandler$DelegatingChannelHandlerContext.fireChannelRead(CombinedChannelDuplexHandler.java:435)
E   	at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:293)
E   	at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:267)
E   	at io.netty.channel.CombinedChannelDuplexHandler.channelRead(CombinedChannelDuplexHandler.java:250)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.handler.timeout.IdleStateHandler.channelRead(IdleStateHandler.java:266)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:345)
E   	at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1294)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:366)
E   	at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:352)
E   	at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:911)
E   	at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:131)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:611)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:552)
E   	at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:466)
E   	at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:438)
E   	at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:140)
E   	at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:144)
E   	at java.lang.Thread.run(Thread.java:1012)

Device sessions

Device 1:

Device 2:

Device 3:

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (43)

Click to expand

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

ulisesmac

Looks good @OmarBasem !

Just one question, in the video, at the end, some schema errors are shown, are they related to this PR?

OmarBasem · 2024-02-27T03:20:53Z

Looks good @OmarBasem !

Just one question, in the video, at the end, some schema errors are shown, are they related to this PR?

Nope not related. I will try to see where they come from and open an issue

mariia-skrypnyk · 2024-02-29T13:31:37Z

Hi @OmarBasem !

Thanks for your PR!
As @J-Son89 mentioned here :

it is mandatory the user inputs a name for a new account, thus the slide button should be disabled.

I have an issue:

ISSUE 1: Slide button on Create Account is enabled if user didn't enter account name

Steps:

Install app
Go to Wallet
Try to create new Account
Do not change Account Name placeholder and slide

Actual result: slide button is active

video_2024-02-29_13-29-56.mp4

Expected result: slide button should be disabled

OmarBasem · 2024-03-01T05:25:03Z

@mariia-skrypnyk thanks for your testing! It should be working as expected now

status-im-auto · 2024-03-04T13:01:22Z

✔️ status-mobile/prs/android-e2e/PR-18922#11 🔹 ~8 min 3 sec 🔹 `a36ea56` 🔹 📦 android-e2e package

OmarBasem · 2024-03-04T13:03:07Z

Thank you @mariia-skrypnyk for your testing and sorry for not noticing this. It is fixed now!

src/quo/components/buttons/slide_button/view.cljs

status-im-auto · 2024-03-04T18:51:19Z

85% of end-end tests have passed

Total executed tests: 48
Failed tests: 6
Expected to fail tests: 1
Passed tests: 41

IDs of failed tests: 702731,702844,703202,703496,702859,702783

IDs of expected to fail tests: 703503

Failed tests (6)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496
Device 1: Click until `ChatMessageInput` by `accessibility id`: `chat-message-input` will be presented Device 1: Looking for a message by text: after unmute critical/chats/test_1_1_public_chats.py:651: in test_1_1_chat_mute_chat self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message text 'should be muted' is not shown in chat preview after mute E Message 'should be muted' is not shown in chat for receiver after mute E New messages counter is not shown after unmute E Message text 'after unmute' is not shown in chat preview after unmute E Message 'after unmute' is not shown in chat for receiver after unmute Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 2: `Text` is `Sent` `critical/chats/test_1_1_public_chats.py:610: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message was not delivered after resending from offline E Message status was not changed to Delivered, it's Sent after back up online!` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_reactions, id: 703202

Device 3: Adding one more 'thumbs-up' reaction or removing an added one
Device 3: Wait for element Button for max 30s and click when it is available

critical/chats/test_group_chat.py:113: in test_group_chat_reactions
    self.chats[2].add_remove_same_reaction(message=message, emoji="thumbs-up")
../views/chat_view.py:1096: in add_remove_same_reaction
    element.wait_and_click()
../views/base_element.py:100: in wait_and_click
    self.wait_for_visibility_of_element(sec)
../views/base_element.py:147: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 3: Button by accessibility id:`emoji-reaction-2` is not found on the screen after wait_for_visibility_of_element

Device sessions

Device 1:

Device 2:

Device 3:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
Device 1: Find `Text` by `xpath`: `//[starts-with(@text,'Message 4')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 1: `Text` is `Sent` `critical/chats/test_1_1_public_chats.py:222: in test_1_1_chat_pin_messages self.chat_1.chat_element_by_text(message).wait_for_status_to_be("Delivered") ../views/chat_view.py:243: in wait_for_status_to_be raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status)) Message status was not changed to Delivered, it's Sent` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMerged:

1. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device 2: Tap on found: SendMessageButton Device 1: Getting preview message for link: https://www.youtube.com/watch?v=XN-SVmuJH2g&list=PLbrz7IuP1hrgNtYe9g6YHwHO6F3OqNMao critical/chats/test_public_chat_browsing.py:585: in test_community_links_with_previews_github_youtube_twitter_gif_send_enable message.wait_for_element(60) ../views/base_element.py:129: in wait_for_element raise TimeoutException( Device `1`: `PreviewMessage` by` xpath`: `//*[starts-with(@text,'https://www.youtube.com/watch?v=XN-SVmuJH2g&list=PLbrz7IuP1hrgNtYe9g6YHwHO6F3OqNMao')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_one_image_send_reply, id: 702859
Device 2: Find `EmojisNumber` by `xpath`: `//[starts-with(@text,'reply to image')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']/../..//[@content-desc='emoji-reaction-1']/android.widget.TextView[2]` Device 2: Element EmojisNumber text is equal to 1 `critical/chats/test_public_chat_browsing.py:501: in test_community_one_image_send_reply self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Reply message was not received by the sender E Image message reaction is not shown for the sender` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (41)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
3. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
4. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs
2. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

mariia-skrypnyk · 2024-03-05T09:00:55Z

Hi @OmarBasem !
Failed e2e are not related to your PR.
Please, go ahead and merge!

OmarBasem self-assigned this Feb 21, 2024

OmarBasem changed the title ~~fix slide button~~ Fix: slide button Feb 21, 2024

OmarBasem added the request-manual-qa label Feb 21, 2024

OmarBasem requested review from briansztamfater, smohamedjavid, J-Son89, ulisesmac, FFFra and shivekkhurana February 21, 2024 07:48

clauxx reviewed Feb 21, 2024

View reviewed changes

src/quo/components/buttons/slide_button/view.cljs Outdated Show resolved Hide resolved

OmarBasem force-pushed the wallet/fix-slider branch from 8c10e64 to 7ba9700 Compare February 21, 2024 12:14

clauxx approved these changes Feb 21, 2024

View reviewed changes

J-Son89 approved these changes Feb 21, 2024

View reviewed changes

pavloburykh force-pushed the wallet/fix-slider branch from b960b49 to 4746535 Compare February 26, 2024 07:49

ulisesmac approved these changes Feb 26, 2024

View reviewed changes

OmarBasem force-pushed the wallet/fix-slider branch from 4746535 to 869aae2 Compare February 29, 2024 06:32

mariia-skrypnyk self-assigned this Feb 29, 2024

mariia-skrypnyk added the Tested - Issues label Feb 29, 2024

OmarBasem force-pushed the wallet/fix-slider branch from 869aae2 to dde815d Compare March 1, 2024 03:31

OmarBasem removed the Tested - Issues label Mar 1, 2024

OmarBasem force-pushed the wallet/fix-slider branch from 15a9f90 to 4d3a303 Compare March 1, 2024 05:24

OmarBasem requested a review from mariia-skrypnyk March 4, 2024 04:50

mariia-skrypnyk added the Tested - Issues label Mar 4, 2024

OmarBasem force-pushed the wallet/fix-slider branch from e2c9b70 to a36ea56 Compare March 4, 2024 12:53

OmarBasem removed the Tested - Issues label Mar 4, 2024

flexsurfer reviewed Mar 4, 2024

View reviewed changes

src/quo/components/buttons/slide_button/view.cljs Outdated Show resolved Hide resolved

mariia-skrypnyk added the test cases required label Mar 4, 2024

OmarBasem added 12 commits March 5, 2024 07:13

fix slide button

5778757

review

23be8a2

lint

ae26609

lint

7ec2a20

lint

7e18faf

lint

74a4eb8

lint

c455094

lint

557cc02

lint

628b78e

qa

47c704d

review

0fc6e3f

lint

62eafef

OmarBasem force-pushed the wallet/fix-slider branch from c97be55 to 62eafef Compare March 5, 2024 03:14

OmarBasem merged commit 62f68ff into develop Mar 5, 2024
6 checks passed

OmarBasem deleted the wallet/fix-slider branch March 5, 2024 03:50

mariia-skrypnyk added the Tested - OK label Mar 5, 2024

mariia-skrypnyk added test cases added and removed test cases required labels Oct 3, 2024

Fix: slide button #18922

Fix: slide button #18922

Conversation

OmarBasem commented Feb 21, 2024 • edited Loading

status-im-auto commented Feb 21, 2024 • edited Loading

Jenkins Builds

J-Son89 left a comment

Choose a reason for hiding this comment

status-im-auto commented Feb 21, 2024

90% of end-end tests have passed

Failed tests (4)

Class TestActivityMultipleDevicePRTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (43)

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestDeepLinksOneDevice:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityMultipleDevicePR:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityMultipleDeviceMergedTwo:

ulisesmac left a comment

Choose a reason for hiding this comment

OmarBasem commented Feb 27, 2024

mariia-skrypnyk commented Feb 29, 2024 • edited Loading

OmarBasem commented Mar 1, 2024

status-im-auto commented Mar 4, 2024

✔️ status-mobile/prs/android-e2e/PR-18922#11 🔹 ~8 min 3 sec 🔹 a36ea56 🔹 📦 android-e2e package

OmarBasem commented Mar 4, 2024

status-im-auto commented Mar 4, 2024

85% of end-end tests have passed

Failed tests (6)

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (41)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestDeepLinksOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePR:

mariia-skrypnyk commented Mar 5, 2024

OmarBasem commented Feb 21, 2024 •

edited

Loading

status-im-auto commented Feb 21, 2024 •

edited

Loading

mariia-skrypnyk commented Feb 29, 2024 •

edited

Loading

✔️ status-mobile/prs/android-e2e/PR-18922#11 🔹 ~8 min 3 sec 🔹 `a36ea56` 🔹 📦 android-e2e package