-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull images from status-go #16976
Pull images from status-go #16976
Conversation
Jenkins BuildsClick to see older builds (12)
|
0% of end-end tests have passed
Failed tests (43)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestActivityMultipleDevicePR:
|
d113cee
to
914bbef
Compare
86% of end-end tests have passed
Failed tests (6)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Passed tests (37)Click to expandClass TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
|
Hi @cammellos Thank you for the PR. The fix in the PR works and the image is displayed in the AC after the reply is sent. Nevertheless, I'm uncertain about the complete list of features that should be done within the scope of this PR. If these reported issues are included within the scope of this PR, kindly address them. If not, the PR can be merged ISSUE 1: Only one image is shown in AC if the album is sent in the reply messageSteps to reproduce:
Actual result:Expected result: |
ISSUE 2: The text is not shown in AC if reply is sent with image and with textSteps to reproduce:
Actual result:The text that was included in the reply is not displayed in the AC. Only image is shown Expected result:The AC should display both the image and the accompanying text in the reply. |
@VolodLytvynenko thank you, if it's ok, I will merge this, and address the others in a separate issue, as they are slightly different and might require different fixes. |
@cammellos Thank you. PR can be merged |
914bbef
to
07c3a33
Compare
@VolodLytvynenko thanks, I had to rebase status-go, could you please re-run e2e on the last build when ready? after that I can merge. |
Sure. Triggered e2e run. I let you know the result |
88% of end-end tests have passed
Failed tests (5)Click to expandClass TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Passed tests (38)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestActivityMultipleDevicePR:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityOneDeviceMerged:
|
@cammellos e2e tests are passed. PR can be merged |
Fixes: #16885 Images were not "prepared" before being sent to the frontend. status-go PR: status-im/status-go#3875 status-im/status-go@1ca165c...d61f983
07c3a33
to
13e9db1
Compare
Fixes: #16885
Images were not "prepared" before being sent to the frontend.
status-go PR: status-im/status-go#3875
status-im/status-go@57e6412...4f413ab