Prepare messages before notifications are sent back #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (9)
|
cammellos
added a commit
to status-im/status-mobile
that referenced
this pull request
Aug 10, 2023
Fixes: #16885 Images were not "prepared" before being sent to the frontend. status-go PR: status-im/status-go#3875 status-im/status-go@57e6412...4f413ab
igor-sirotin
approved these changes
Aug 11, 2023
cammellos
force-pushed
the
bug/fix-notification-image
branch
from
4f413ab
to
aeb116f
Compare
cammellos
added a commit
to status-im/status-mobile
that referenced
this pull request
Aug 11, 2023
Fixes: #16885 Images were not "prepared" before being sent to the frontend. status-go PR: status-im/status-go#3875 status-im/status-go@9896ec8...aeb116f
cammellos
force-pushed
the
bug/fix-notification-image
branch
from
aeb116f
to
a9010f9
Compare
cammellos
added a commit
to status-im/status-mobile
that referenced
this pull request
Aug 11, 2023
Fixes: #16885 Images were not "prepared" before being sent to the frontend. status-go PR: status-im/status-go#3875 status-im/status-go@daa9ad4...a9010f9
cammellos
force-pushed
the
bug/fix-notification-image
branch
from
a9010f9
to
710b020
Compare
cammellos
added a commit
to status-im/status-mobile
that referenced
this pull request
Aug 11, 2023
Fixes: #16885 Images were not "prepared" before being sent to the frontend. status-go PR: status-im/status-go#3875 status-im/status-go@52fb1cd...710b020
cammellos
added a commit
to status-im/status-mobile
that referenced
this pull request
Aug 14, 2023
Fixes: #16885 Images were not "prepared" before being sent to the frontend. status-go PR: status-im/status-go#3875 status-im/status-go@1ca165c...d61f983
cammellos
added a commit
to status-im/status-mobile
that referenced
this pull request
Aug 14, 2023
Fixes: #16885 Images were not "prepared" before being sent to the frontend. status-go PR: status-im/status-go#3875 status-im/status-go@1ca165c...d61f983
andresceballosm
pushed a commit
to andresceballosm/status-mobile
that referenced
this pull request
Aug 29, 2023
Fixes: status-im#16885 Images were not "prepared" before being sent to the frontend. status-go PR: status-im/status-go#3875 status-im/status-go@f2f599f...d61f983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When notifications were queried, the message wasn't prepared, resulting in an empty image url.