Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint and fix missing trailing newlines #16445

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Lint and fix missing trailing newlines #16445

merged 2 commits into from
Jul 4, 2023

Conversation

ilmotta
Copy link
Contributor

@ilmotta ilmotta commented Jun 29, 2023 •
edited
Loading

Summary

While reviewing a PR today I was about to make a comment for the collaborator to follow the Clojure Style Guide and POSIX and make sure all lines are valid (A sequence of zero or more non- characters plus a terminating character).

But this would be the 100th time I would make this kind of comment. Therefore, this PR automates the lint and lint-fix targets to take into account this rule that, unfortunately, is not supported by any of the tools we use (such as zprint). Well, not that I know of.

Notes

Is it fast?

I think yes, fast enough, adds a negligible amount of time to our already quite slow lint targets.

status: ready

@ilmotta ilmotta added the chore label Jun 29, 2023
@ilmotta ilmotta self-assigned this Jun 29, 2023
@status-im-auto
Copy link
Member

status-im-auto commented Jun 29, 2023 •
edited
Loading

Jenkins Builds

Click to see older builds (16)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 55b21e4 #1 2023-06-29 19:02:47 ~6 min ios 📱ipa 📲
✔️ 55b21e4 #1 2023-06-29 19:02:50 ~6 min android 🤖apk 📲
✔️ 55b21e4 #1 2023-06-29 19:02:55 ~6 min android-e2e 🤖apk 📲
✔️ 55b21e4 #1 2023-06-29 19:04:54 ~8 min tests 📄log
❌ ce61da5 #2 2023-06-30 12:05:25 ~4 min tests 📄log
✔️ ce61da5 #2 2023-06-30 12:09:43 ~8 min ios 📱ipa 📲
✔️ ce61da5 #2 2023-06-30 12:10:42 ~9 min android-e2e 🤖apk 📲
✔️ ce61da5 #2 2023-06-30 12:10:48 ~9 min android 🤖apk 📲
✔️ e3d64f7 #3 2023-06-30 14:03:18 ~6 min android 🤖apk 📲
✔️ e3d64f7 #3 2023-06-30 14:04:22 ~7 min ios 📱ipa 📲
✔️ e3d64f7 #3 2023-06-30 14:05:53 ~8 min android-e2e 🤖apk 📲
✔️ e3d64f7 #3 2023-06-30 14:07:26 ~10 min tests 📄log
❌ 47f3dd3 #4 2023-07-04 10:28:34 ~2 min tests 📄log
✔️ 47f3dd3 #4 2023-07-04 10:32:35 ~6 min android-e2e 🤖apk 📲
✔️ 47f3dd3 #4 2023-07-04 10:33:28 ~7 min ios 📱ipa 📲
✔️ 47f3dd3 #4 2023-07-04 10:33:31 ~7 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ fd50e38 #5 2023-07-04 10:49:36 ~2 min tests 📄log
✔️ fd50e38 #5 2023-07-04 10:52:38 ~5 min ios 📱ipa 📲
✔️ fd50e38 #5 2023-07-04 10:53:27 ~6 min android-e2e 🤖apk 📲
✔️ fd50e38 #5 2023-07-04 10:54:16 ~7 min android 🤖apk 📲
✔️ d4beb0e #6 2023-07-04 19:22:14 ~5 min ios 📱ipa 📲
✔️ d4beb0e #6 2023-07-04 19:22:18 ~5 min android-e2e 🤖apk 📲
✔️ d4beb0e #6 2023-07-04 19:24:05 ~7 min android 🤖apk 📲
✔️ d4beb0e #6 2023-07-04 19:25:02 ~8 min tests 📄log

jakubgs
jakubgs approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@J-Son89
Copy link
Contributor

J-Son89 commented Jun 30, 2023

Muito bom! 🚀

@status-im-auto
Copy link
Member

85% of end-end tests have passed

Total executed tests: 33
Failed tests: 5
Passed tests: 28

IDs of failed tests: 702786,702732,702894,702731,703133

Failed tests (5)

Click to expand
  • Rerun failed tests

    • Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732 
    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_mentions_push_notification, id: 702786

    # STEP: Admin gets push notification with the mention and tap it
    Device 1: Getting PN by 'user_1' 

    critical/test_public_chat_browsing.py:907: in test_community_mentions_push_notification
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Push notification with the mention was not received by admin



    Device sessions

    2. test_community_contact_block_unblock_offline, id: 702894

    Device 1: Tap on found: Button
    Device 1: Looking for a message by text: Hurray! unblocked 

    critical/test_public_chat_browsing.py:780: in test_community_contact_block_unblock_offline
    self.errors.verify_no_errors()
base_test_case.py:182: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Hurray! unblocked was not received in public chat after user unblock!



    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

    Device 1: Tap on found: ProfileSendMessageButton
    Device 1: Find Text by xpath: //*[@content-desc='user-avatar']/../following-sibling::android.widget.TextView 

    critical/test_public_chat_browsing.py:391: in test_restore_multiaccount_with_waku_backup_remove_switch
    shown_name_text = chat.user_name_text_new_UI.text
../views/base_element.py:391: in text
    text = self.find_element().text
../views/base_element.py:80: in find_element
    raise NoSuchElementException(
 Device 1: Text by xpath: `//*[@content-desc='user-avatar']/../following-sibling::android.widget.TextView` is not found on the screen



    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_pin_messages, id: 702731 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Pin feature is in development]]

    Passed tests (28)

    Click to expand

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    3. test_activity_center_mentions, id: 702957
    Device sessions

    4. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    2. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    3. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    4. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    5. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    6. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    7. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    8. test_1_1_chat_edit_message, id: 702855
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    2. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_join_send_text_messages_push, id: 702807
    Device sessions

    2. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    2. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    3. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    4. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    5. test_community_message_edit, id: 702843
    Device sessions

    6. test_community_message_delete, id: 702839
    Device sessions

    7. test_community_unread_messages_badge, id: 702841
    Device sessions

    8. test_community_one_image_send_reply, id: 702859
    Device sessions

    9. test_community_several_images_send_reply, id: 703194
    Device sessions

    10. test_community_leave, id: 702845
    Device sessions

    @ilmotta ilmotta force-pushed the chore/lint-hunt-and-fix-missing-newlines branch from 55b21e4 to ce61da5 Compare June 30, 2023 12:01
    @ilmotta ilmotta force-pushed the chore/lint-hunt-and-fix-missing-newlines branch 3 times, most recently from 47f3dd3 to fd50e38 Compare July 4, 2023 10:46
    @ilmotta ilmotta force-pushed the chore/lint-hunt-and-fix-missing-newlines branch from fd50e38 to d4beb0e Compare July 4, 2023 19:16
    @ilmotta ilmotta merged commit 19ca8e2 into develop Jul 4, 2023
    @ilmotta ilmotta deleted the chore/lint-hunt-and-fix-missing-newlines branch July 4, 2023 19:40
    codemaster115 pushed a commit that referenced this pull request Jul 7, 2023
    @ilmotta @codemaster115
    Lint and fix missing trailing newlines (#16445)
    ee0fe1e 
    Apply the Clojure Style Guide recommendation to end files with proper lines
(having a trailing newline character). See
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap03.html#tag_03_206
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @jakubgs jakubgs jakubgs approved these changes

    @siddarthkay siddarthkay siddarthkay approved these changes

    @flexsurfer flexsurfer flexsurfer approved these changes

    @vkjr vkjr vkjr approved these changes

    @rahulpsingh rahulpsingh Awaiting requested review from rahulpsingh

    Assignees

    @ilmotta ilmotta

    Labels
    None yet
    Projects
    No open projects
    Legacy QA Automation Project
    Archived in project
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    7 participants
    @ilmotta @status-im-auto @J-Son89 @jakubgs @vkjr @flexsurfer @siddarthkay