fix hole view usage for create profile picture #16001

Parveshdhull · 2023-05-23T19:30:16Z

Testing

Please make sure Profile icon disappears after setting up profile picture (Android) #15553 is still fixed (also in ios)
hole view is used for camera icon, fixes fix create profile issues #15561 (comment)

status: ready

status-im-auto · 2023-05-23T19:32:42Z

Jenkins Builds

Click to see older builds (33)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`9a82b22`	#1	2023-05-23 19:32:42	~2 min	`ios`	📄`log`

❌	`29451ff`	#2	2023-05-23 19:36:34	~1 min	`ios`	📄`log`
✔️	`29451ff`	#2	2023-05-23 19:40:42	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`29451ff`	#2	2023-05-23 19:40:42	~5 min	`android`	🤖`apk` 📲
✔️	`29451ff`	#2	2023-05-23 19:41:55	~6 min	`tests`	📄`log`

✔️	`75e452a`	#3	2023-05-26 08:57:55	~8 min	`android`	🤖`apk` 📲
✔️	`75e452a`	#3	2023-05-26 08:58:49	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`75e452a`	#3	2023-05-26 09:00:50	~11 min	`ios`	📱`ipa` 📲
✔️	`75e452a`	#3	2023-05-26 09:02:39	~12 min	`tests`	📄`log`

❌	`f29de84`	#5	2023-06-07 18:52:35	~3 min	`tests`	📄`log`
✔️	`f29de84`	#5	2023-06-07 18:54:36	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`f29de84`	#5	2023-06-07 18:54:58	~5 min	`android`	🤖`apk` 📲
✔️	`f29de84`	#5	2023-06-07 18:55:34	~6 min	`ios`	📱`ipa` 📲

✔️	`e74cae4`	#6	2023-06-07 19:03:40	~5 min	`ios`	📱`ipa` 📲
✔️	`e74cae4`	#6	2023-06-07 19:03:51	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`e74cae4`	#6	2023-06-07 19:03:57	~6 min	`android`	🤖`apk` 📲
❌	`e74cae4`	#6	2023-06-07 19:05:30	~7 min	`tests`	📄`log`

✔️	`b9892d9`	#7	2023-06-07 19:24:40	~5 min	`ios`	📱`ipa` 📲
✔️	`b9892d9`	#7	2023-06-07 19:25:12	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`b9892d9`	#7	2023-06-07 19:25:13	~6 min	`android`	🤖`apk` 📲
✔️	`b9892d9`	#7	2023-06-07 19:26:43	~7 min	`tests`	📄`log`

✔️	`794fe68`	#8	2023-06-08 11:07:00	~5 min	`android`	🤖`apk` 📲
✔️	`794fe68`	#8	2023-06-08 11:07:18	~5 min	`ios`	📱`ipa` 📲
✔️	`794fe68`	#8	2023-06-08 11:08:26	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`794fe68`	#8	2023-06-08 11:10:01	~8 min	`tests`	📄`log`

✔️	`138ef54`	#9	2023-06-08 11:18:21	~5 min	`ios`	📱`ipa` 📲
✔️	`138ef54`	#9	2023-06-08 11:19:39	~7 min	`android`	🤖`apk` 📲
✔️	`138ef54`	#9	2023-06-08 11:21:08	~8 min	`tests`	📄`log`
✔️	`138ef54`	#9	2023-06-08 11:21:24	~8 min	`android-e2e`	🤖`apk` 📲

✔️	`2dd5cd4`	#11	2023-06-08 11:34:15	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`2dd5cd4`	#11	2023-06-08 11:34:24	~5 min	`android`	🤖`apk` 📲
✔️	`2dd5cd4`	#11	2023-06-08 11:35:03	~6 min	`ios`	📱`ipa` 📲
✔️	`2dd5cd4`	#11	2023-06-08 11:36:43	~7 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`37dc843`	#13	2023-06-08 15:44:27	~5 min	`android`	🤖`apk` 📲
✔️	`37dc843`	#13	2023-06-08 15:45:07	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`37dc843`	#13	2023-06-08 15:46:26	~7 min	`ios`	📱`ipa` 📲
✔️	`37dc843`	#13	2023-06-08 15:46:27	~7 min	`tests`	📄`log`

✔️	`208c890`	#14	2023-06-09 08:42:05	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`208c890`	#14	2023-06-09 08:42:05	~6 min	`android`	🤖`apk` 📲
✔️	`208c890`	#14	2023-06-09 08:42:57	~6 min	`tests`	📄`log`
✔️	`208c890`	#14	2023-06-09 08:45:00	~9 min	`ios`	📱`ipa` 📲
✔️	`208c890`	#15	2023-06-09 08:51:00	~5 min	`android-e2e`	🤖`apk` 📲

status-im-auto · 2023-05-26T10:03:00Z

70% of end-end tests have passed

Total executed tests: 33
Failed tests: 10
Passed tests: 23

IDs of failed tests: 702733,702855,702745,702782,703133,702783,702731,702838,702813,702784

Failed tests (10)

Click to expand

Rerun failed tests

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device 1: Wait for element `Button` for max 30s and click when it is available
Device 1: Find `Button` by `accessibility id`: `skip-identifiers`

critical/test_public_chat_browsing.py:354: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.sign_in.recover_access(passphrase=waku_user.seed, second_user=True)
../views/sign_in_view.py:265: in recover_access
    self.identifiers_button.wait_and_click(30)
../views/base_element.py:404: in wait_and_click
    self.click()
../views/base_element.py:91: in click
    self.find_element().click()
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:80: in click
    self._execute(Command.CLICK_ELEMENT)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webelement.py:633: in _execute
    return self._parent.execute(command, params)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute
    self.error_handler.check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response
    raise wde
/home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response
    super().check_response(response)
/home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:242: in check_response
    raise exception_class(message, screen, stacktrace)
 The element 'By.accessibilityId: skip-identifiers' does not exist in DOM anymore

Device sessions

Device 1:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device 2: Find `Button` by `accessibility id`: `jump-to` critical/chats/test_1_1_public_chats.py:1138: in test_1_1_chat_text_message_delete_push_disappear self.chat_2.jump_to_card_by_text(self.username_1) ../views/base_view.py:609: in jump_to_card_by_text self.jump_to_button.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `jump-to` is not found on the screen; also Unexpected Alert is shown: 'Invalid arity: 0'; also Unexpected Alert is shown: 'Invalid arity: 0' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_edit_message, id: 702855
Device 2: Could not reach ChatsTab element by pressing back Device 2: Find `Button` by `accessibility id`: `jump-to` critical/chats/test_1_1_public_chats.py:1122: in test_1_1_chat_edit_message self.chat_2.jump_to_card_by_text(self.username_1) ../views/base_view.py:609: in jump_to_card_by_text self.jump_to_button.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `jump-to` is not found on the screen; also Unexpected Alert is shown: 'Invalid arity: 0'; also Unexpected Alert is shown: 'Invalid arity: 0' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device 1: Could not reach ChatsTab element by pressing back Device 1: Find `ChatsTab` by `accessibility id`: `chats-stack-tab` critical/chats/test_1_1_public_chats.py:1030: in test_1_1_chat_non_latin_messages_stack_update_profile_photo self.home_1.profile_button.click() ../views/base_view.py:141: in click ChatsTab(self.driver).click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 1: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; also Unexpected Alert is shown: 'Invalid arity: 0'; also Unexpected Alert is shown: 'Invalid arity: 0' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
4. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device 1: Find `Button` by `xpath`: `//[contains(@text, "⛵")]` Device 1: Long press on `Button` until expected element is shown critical/chats/test_1_1_public_chats.py:896: in test_1_1_chat_emoji_send_reply_and_open_link self.chat_1.quote_message(emoji_unicode) ../views/chat_view.py:994: in quote_message self.element_by_text_part(message).long_press_until_element_is_shown(self.reply_message_button) ../views/base_element.py:302: in long_press_until_element_is_shown action.long_press(element).release().perform() /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/common/touch_action.py:163: in perform self._driver.execute(Command.TOUCH_ACTION, params) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:321: in execute self.error_handler.check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:31: in check_response raise wde /home/jenkins/.local/lib/python3.10/site-packages/appium/webdriver/errorhandler.py:26: in check_response super().check_response(response) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/errorhandler.py:242: in check_response raise exception_class(message, screen, stacktrace) The element 'By.xpath: //[contains(@text, "⛵")]' does not exist in DOM anymore; also Unexpected Alert is shown: 'Invalid arity: 0'; also Unexpected Alert is shown: 'Invalid arity: 0' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
5. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 2: Find `Button` by `accessibility id`: `jump-to` critical/chats/test_1_1_public_chats.py:1192: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.chat_2.jump_to_card_by_text(self.username_1) ../views/base_view.py:609: in jump_to_card_by_text self.jump_to_button.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `jump-to` is not found on the screen; also Unexpected Alert is shown: 'Invalid arity: 0'; also Unexpected Alert is shown: 'Invalid arity: 0' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
6. test_1_1_chat_pin_messages, id: 702731
# STEP: Check that Device1 can pin own message in 1-1 chat Device 2: Find `Button` by `accessibility id`: `jump-to` critical/chats/test_1_1_public_chats.py:940: in test_1_1_chat_pin_messages self.chat_2.jump_to_card_by_text(self.username_1) ../views/base_view.py:609: in jump_to_card_by_text self.jump_to_button.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: Button by accessibility id: `jump-to` is not found on the screen; also Unexpected Alert is shown: 'Invalid arity: 0'; also Unexpected Alert is shown: 'Invalid arity: 0' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
7. test_1_1_chat_push_emoji, id: 702813
Device 2: Could not reach ChatsTab element by pressing back Device 2: Find `ChatsTab` by `accessibility id`: `chats-stack-tab` critical/chats/test_1_1_public_chats.py:1072: in test_1_1_chat_push_emoji self.home_2.profile_button.click() ../views/base_view.py:141: in click ChatsTab(self.driver).click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; also Unexpected Alert is shown: 'Invalid arity: 0'; also Unexpected Alert is shown: 'Invalid arity: 0' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
8. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device 2: Could not reach ChatsTab element by pressing back Device 2: Find `ChatsTab` by `accessibility id`: `chats-stack-tab` critical/chats/test_1_1_public_chats.py:1235: in test_1_1_chat_delete_via_long_press_relogin self.home_2.chats_tab.click() ../views/base_element.py:91: in click self.find_element().click() ../views/base_element.py:80: in find_element raise NoSuchElementException( Device 2: ChatsTab by accessibility id: `chats-stack-tab` is not found on the screen; also Unexpected Alert is shown: 'Invalid arity: 0'; also Unexpected Alert is shown: 'Invalid arity: 0' Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMerged:

1. test_community_message_send_check_timestamps_sender_username, id: 702838

Device 2: Verifying that 'hello' is under today
Device 2: Looking for a message by text: hello

critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username
    channel.verify_message_is_under_today_text(message, self.errors)
../views/chat_view.py:944: in verify_message_is_under_today_text
    message_element.wait_for_visibility_of_element()
../views/base_element.py:135: in wait_for_visibility_of_element
    raise TimeoutException(
 Device 2: ChatElementByText by xpath:`//*[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element

[[blocked by 14797]]

Device sessions

Device 1:

Device 2:

Passed tests (23)

Click to expand

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

pavloburykh · 2023-05-26T12:20:05Z

@Parveshdhull Thanx for the PR! Please, take a look at the following issues.

ISSUE 1 Accent color is not applied for empty (default) profile icon (Android)

Reproduced on Samsung Galaxy A52, Andrdoid 12

Steps:

Open Create Profile onboarding step
Start changing accent colors
See if color are applied to profile icon

Actual result:

Accent color is not applied for empty (default) profile icon

telegram-cloud-document-2-5442686835002192664.mp4

pavloburykh · 2023-05-26T12:20:24Z

ISSUE 2 Symbols inside default icon are not updated while typing name and dispositioned (Android)

Reproduced on Samsung Galaxy A52, Andrdoid 12

Steps:

Open Create Profile onboarding step
Start typing name
See if symbols are updated according to entered name value
See if symbols are not dispositioned

Actual result: symbols inside default icon are not updated while typing name and get dispositioned. Sometimes only 1 symbol is updated regardless multiword name value is entered.

telegram-cloud-document-2-5442686835002192668.mp4

pavloburykh · 2023-05-26T12:20:28Z

ISSUE 3 Wrong hole color?

Not sure about this one. @Parveshdhull could you please re-check and confirm that colors are the same as on design. Looks like hole color is lighter than currently implemented.

Actual result:

IOS:

Android:

Expected result:

https://www.figma.com/file/o4qG1bnFyuyFOvHQVGgeFY/Onboarding-for-Mobile?type=design&node-id=2241-251162&t=SWwcLHfABEwbl6L6-0

Onboarding for Mobile – Figma 2023-05-26 14-29-53

pavloburykh · 2023-05-26T12:30:05Z

ISSUE 4 Profile icons with set pictures disappear on login/profile list screens after app being in background for a while (IOS)

Reproduced on iPhone X, IOS 14.1

@Parveshdhull actually I am not sure if this is PR related. I also faced it while testing release build. Logging here because you asked to check this fix #15553

Preconditions: user has set profile picture.

Steps: (these steps are not 100% reliable)

Open Profile list screeen
Background app for some time. (2-5 minutes)
Open app
See if profile icons are displayed
If still displayed - open any profile from the list
See if profile picture is displayed on login screen
If profile picture is not displayed - go back to profile list screen and see if profile pictures are displayed

Actual result: sometimes profile icons with set pictures disappear on login/profile list screens

telegram-cloud-document-2-5442686835002192700.mp4

Parveshdhull · 2023-06-07T19:03:23Z

hi @pavloburykh, Thank you very much for testing the PR and for your patience.
Issues 1 & 2 should be fixed now.

For issue 3, I checked the camera icon color (white - 5% opacity) and the background color (primary - 50 - 40% opacity) are the same as Figma.
Still, they look different to me too.

As they are transparent, their net result also gets affected by background color. Which might be different than Figma, maybe due to different background slide or issues in blur view.
Device specific color vibrancy etc, not sure.

Is Issue 4 still reproducible? If yes, probably something related to image server, Please feel free to log it.

pavloburykh · 2023-06-08T09:14:56Z

Hi @Parveshdhull ! thanx for your work and fixes. Please, take a look at a few new issues.

ISSUE 5 Profile picture is not shown after being set until some action that triggers prophile icon reload (typing text/changing accent color) [ANDROID only]

Reproducible on Android 12, Samsung Galaxy A52

Steps:

Proceed to Create Profile screen
Set profile picture
See if Profile picture is shown

Actual result: Profile picture is not shown after being set until some action that triggers prophile icon reload (typing text/changing accent color)

telegram-cloud-document-2-5193199756804892190.mp4

Expected result: profile picture is shown

pavloburykh · 2023-06-08T09:15:00Z

ISSUE 6 Loading spinner appears in profile icon during typing/cnhaging accent color [IOS]

This is a minor one. If you consider to fix it as followup let me know and I will log a separate issue.

Reproducible in IOS 14.1, iPhone X

Steps:

Proceed to Create Profile screen
Set profile picture
Start typing name/changing accent color
See if loading spinner is visible on profile icon

Actual result: loading spinner appears in profile icon during typing/cnhaging accent color

telegram-cloud-document-2-5193199756804892193.mp4

Expected result: if it is possible - we would better not show that spinner. BTW is there any reason why we are updating profile icon so frequently during typing (after each letter is typed)?

pavloburykh · 2023-06-08T09:16:04Z

Is Issue 4 still reproducible? If yes, probably something related to image server, Please feel free to log it.

Sure, I will try to catch it and log separately if it is still there. Thank you!

Parveshdhull · 2023-06-08T11:08:48Z

hi @pavloburykh, Issue 5 & 6, should be fixed now.

Expected result: if it is possible - we would better not show that spinner. BTW is there any reason why we are updating profile icon so frequently during typing (after each letter is typed)?

Good question.

Our implementation of fast image shows loading spinner until image is not loaded.
And as we are using hole-view for camera icon, dynamic updates like changing image, user name, customization color don't directly work. We have to force re-render user avatar. Dynamic updates inside the hole-view not working in Android #15577
And as every time user avatar was re-created, it was showing that spinner.

Now, we are using simple image view, instead of fast-image. So it should be fixed.

Parveshdhull · 2023-06-08T11:25:27Z

Now, we are using simple image view, instead of fast-image.

Also added check to make sure, only re-render every-time while typing when no image is present, otherwise only re-render when image is updated.

pavloburykh · 2023-06-08T14:07:29Z

hi @pavloburykh, Issue 5 & 6, should be fixed now.

@Parveshdhull Thanx for the fixes and explanation!

I have 1 more minor behaviour which I am not sure to be expected or not. If it is expected - PR is ready to be merged.

ISSUE 7 Abbreviation of "Your name" placeholder is not displayed in Profile icon if some text has been already entered and then cleared

Steps:

Proceed to Create profile screen
Type some text in the input filed
Clear the input field
See if YN abbreviation (for "Your name" placeholder) is displayed inside Profile icon

Actual result: abbreviation is not displayed

telegram-cloud-document-2-5192813995727269006.mp4

Expected result: abbreviation should be displayed

Parveshdhull · 2023-06-08T15:35:21Z

I have 1 more minor behaviour which I am not sure to be expected or not.

Lets fix this one too

pavloburykh · 2023-06-09T08:32:01Z

@Parveshdhull thanx for your work and patience! PR is ready to be merged.

Parveshdhull added the request-manual-qa label May 23, 2023

Parveshdhull requested a review from J-Son89 May 23, 2023 19:30

Parveshdhull self-assigned this May 23, 2023

Parveshdhull force-pushed the fix/hole-view-create-profile branch from 9a82b22 to 29451ff Compare May 23, 2023 19:34

Parveshdhull requested a review from ibrkhalil May 23, 2023 19:35

J-Son89 approved these changes May 24, 2023

View reviewed changes

pavloburykh force-pushed the fix/hole-view-create-profile branch from 29451ff to 75e452a Compare May 26, 2023 08:49

pavloburykh self-assigned this May 26, 2023

pavloburykh added the Tested - Issues label May 26, 2023

Parveshdhull force-pushed the fix/hole-view-create-profile branch 2 times, most recently from a40190c to f29de84 Compare June 7, 2023 18:48

Parveshdhull force-pushed the fix/hole-view-create-profile branch 2 times, most recently from 138ef54 to 6166681 Compare June 8, 2023 11:23

Parveshdhull force-pushed the fix/hole-view-create-profile branch from 7828e31 to 37dc843 Compare June 8, 2023 15:38

pavloburykh added Tested - OK and removed Tested - Issues labels Jun 9, 2023

fix hole view usage for create profile picture

208c890

Parveshdhull force-pushed the fix/hole-view-create-profile branch from 37dc843 to 208c890 Compare June 9, 2023 08:35

Parveshdhull merged commit 9b52bba into develop Jun 9, 2023

Parveshdhull deleted the fix/hole-view-create-profile branch June 9, 2023 08:45

codemaster115 pushed a commit that referenced this pull request Jun 16, 2023

fix hole view usage for create profile picture (#16001)

fe403ef

Parveshdhull mentioned this pull request Jun 19, 2023

Dynamic updates inside the hole-view not working in Android #15577

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix hole view usage for create profile picture #16001

fix hole view usage for create profile picture #16001

Parveshdhull commented May 23, 2023 •

edited

Loading

status-im-auto commented May 23, 2023 •

edited

Loading

status-im-auto commented May 26, 2023

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

pavloburykh commented May 26, 2023

pavloburykh commented May 26, 2023 •

edited

Loading

pavloburykh commented May 26, 2023

pavloburykh commented May 26, 2023 •

edited

Loading

Parveshdhull commented Jun 7, 2023 •

edited

Loading

pavloburykh commented Jun 8, 2023

pavloburykh commented Jun 8, 2023

pavloburykh commented Jun 8, 2023

Parveshdhull commented Jun 8, 2023

Parveshdhull commented Jun 8, 2023

pavloburykh commented Jun 8, 2023

Parveshdhull commented Jun 8, 2023 •

edited

Loading

pavloburykh commented Jun 9, 2023 •

edited

Loading

fix hole view usage for create profile picture #16001

fix hole view usage for create profile picture #16001

Conversation

Parveshdhull commented May 23, 2023 • edited Loading

Testing

status-im-auto commented May 23, 2023 • edited Loading

Jenkins Builds

status-im-auto commented May 26, 2023

70% of end-end tests have passed

Failed tests (10)

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Passed tests (23)

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePR:

pavloburykh commented May 26, 2023

ISSUE 1 Accent color is not applied for empty (default) profile icon (Android)

pavloburykh commented May 26, 2023 • edited Loading

ISSUE 2 Symbols inside default icon are not updated while typing name and dispositioned (Android)

pavloburykh commented May 26, 2023

ISSUE 3 Wrong hole color?

pavloburykh commented May 26, 2023 • edited Loading

ISSUE 4 Profile icons with set pictures disappear on login/profile list screens after app being in background for a while (IOS)

Parveshdhull commented Jun 7, 2023 • edited Loading

pavloburykh commented Jun 8, 2023

ISSUE 5 Profile picture is not shown after being set until some action that triggers prophile icon reload (typing text/changing accent color) [ANDROID only]

pavloburykh commented Jun 8, 2023

ISSUE 6 Loading spinner appears in profile icon during typing/cnhaging accent color [IOS]

pavloburykh commented Jun 8, 2023

Parveshdhull commented Jun 8, 2023

Parveshdhull commented Jun 8, 2023

pavloburykh commented Jun 8, 2023

ISSUE 7 Abbreviation of "Your name" placeholder is not displayed in Profile icon if some text has been already entered and then cleared

Parveshdhull commented Jun 8, 2023 • edited Loading

pavloburykh commented Jun 9, 2023 • edited Loading

Parveshdhull commented May 23, 2023 •

edited

Loading

status-im-auto commented May 23, 2023 •

edited

Loading

pavloburykh commented May 26, 2023 •

edited

Loading

pavloburykh commented May 26, 2023 •

edited

Loading

Parveshdhull commented Jun 7, 2023 •

edited

Loading

Parveshdhull commented Jun 8, 2023 •

edited

Loading

pavloburykh commented Jun 9, 2023 •

edited

Loading