Skip to content

Dynamic updates inside the hole-view not working in Android #15577

Closed as not planned

Description

Problem

For creating mask effect/holes, we overlap components inside the hole-view.

This component should be static, if it is dynamic like getting an update with reanimated or some reagent atom then those updates don't work in Android.

Currently, we have a way around for cases with reagent updates. We can just pass a param key to the hole key and update that with the help of a reagent atom, which will force rerender hole-view and child components.

But this is not an optimal solution because rerendering degrades the performance and shouldn't be used for fast response time components like bottom tabs.

Although re-rendering with the help of key param works almost in all cases, for some reason it didn't update the view which was using fast-image instead of the react-native image component.

UPD: Fast-image itself usage reagent atom to dynamically update view when image is loaded, that's why it don't work inside hole-view. Because even if we rerender fast-image view, initial state is still loading and we update image after that

We should look into this library to figure out why behaviour is different in android and ios, and fix issue: #15561 (comment)
UPD: fixed create profile issue in #16001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions