use debounce-and-dispatch to improve mention performance #15887

qfrank · 2023-05-12T13:29:42Z

Summary

used debounce-and-dispatch to reduce times of calling wakuext_chatMentionOnChangeText
removed unused code relate to mention
combined wakuext_chatMentionRecheckAtIdxs and wakuext_chatMentionNewInputTextWithMention

relate PR for status-go

thanks to @ilmotta to let me know we have debounce-and-dispatch

Testing notes

it should improve the performance of mention and mention should work as before

Platforms

Android
iOS

status: ready

status-im-auto · 2023-05-12T13:38:13Z

Jenkins Builds

Click to see older builds (12)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`fd78cce`	#1	2023-05-12 13:38:13	~8 min	`android-e2e`	🤖`apk` 📲
✔️	`fd78cce`	#1	2023-05-12 13:38:16	~8 min	`android`	🤖`apk` 📲
✔️	`fd78cce`	#1	2023-05-12 13:38:34	~8 min	`tests`	📄`log`
✔️	`fd78cce`	#1	2023-05-12 13:40:25	~10 min	`ios`	📱`ipa` 📲

✔️	`29bba83`	#2	2023-05-12 14:16:24	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`29bba83`	#2	2023-05-12 14:16:33	~5 min	`android`	🤖`apk` 📲
✔️	`29bba83`	#2	2023-05-12 14:17:05	~6 min	`tests`	📄`log`
✔️	`29bba83`	#2	2023-05-12 14:19:21	~8 min	`ios`	📱`ipa` 📲

✔️	`c98df10`	#3	2023-05-15 03:31:43	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`c98df10`	#3	2023-05-15 03:31:53	~5 min	`tests`	📄`log`
✔️	`c98df10`	#3	2023-05-15 03:32:34	~6 min	`ios`	📱`ipa` 📲
✔️	`c98df10`	#3	2023-05-15 03:34:16	~8 min	`android`	🤖`apk` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`abdc385`	#4	2023-05-15 07:35:06	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`abdc385`	#4	2023-05-15 07:35:06	~9 min	`android`	🤖`apk` 📲
✔️	`abdc385`	#4	2023-05-15 07:35:12	~9 min	`tests`	📄`log`
✔️	`abdc385`	#4	2023-05-15 07:36:20	~10 min	`ios`	📱`ipa` 📲

✔️	`544e1e1`	#5	2023-05-15 07:49:42	~7 min	`android`	🤖`apk` 📲
✔️	`544e1e1`	#5	2023-05-15 07:50:23	~8 min	`ios`	📱`ipa` 📲
✔️	`544e1e1`	#5	2023-05-15 07:51:17	~9 min	`tests`	📄`log`
✔️	`544e1e1`	#5	2023-05-15 07:51:51	~9 min	`android-e2e`	🤖`apk` 📲

flexsurfer · 2023-05-12T14:01:29Z

src/status_im2/contexts/chat/composer/handlers.cljs

@@ -118,7 +119,7 @@
    (@record-reset-fn)
    (reset! recording? false))
  (rf/dispatch [:chat.ui/set-chat-input-text text])
-  (rf/dispatch [:mention/on-change-text text]))
+  (debounce/debounce-and-dispatch [:mention/on-change-text text] 200))


have tried different values ? 400 sounds better ?

tried 200/300/400, 400 is a bit slow in response, 300 seems reasonable 👍@flexsurfer

status-im-auto · 2023-05-12T15:24:53Z

77% of end-end tests have passed

Total executed tests: 31
Failed tests: 7
Passed tests: 24

IDs of failed tests: 702732,702786,702813,702838,702783,702808,702807

Failed tests (7)

Click to expand

Rerun failed tests

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Test setup failed: /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request six.raise_from(e, None) <string>:3: in raise_from ??? /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request httplib_response = conn.getresponse() /usr/lib/python3.10/http/client.py:1374: in getresponse response.begin() /usr/lib/python3.10/http/client.py:318: in begin version, status, reason = self._read_status() /usr/lib/python3.10/http/client.py:287: in _read_status raise RemoteDisconnected("Remote end closed connection without" E http.client.RemoteDisconnected: Remote end closed connection without response During handling of the above exception, another exception occurred: critical/chats/test_group_chat.py:195: in prepare_devices self.homes[0].just_fyi('Admin creates group chat') ../views/base_view.py:368: in just_fyi self.driver.execute_script("sauce:context=STEP: %s" % some_str) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script return self.execute(command, { /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:319: in execute response = self.command_executor.execute(driver_command, params) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:376: in execute return self._request(command_info[0], url, body=data) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:399: in _request resp = self._conn.request(method, url, body=body, headers=headers) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:78: in request return self.request_encode_body( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:170: in request_encode_body return self.urlopen(method, url, extra_kw) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/poolmanager.py:376: in urlopen response = conn.urlopen(method, u.request_uri, kw) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:787: in urlopen retries = retries.increment( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/util/retry.py:550: in increment raise six.reraise(type(error), error, _stacktrace) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/packages/six.py:769: in reraise raise value.with_traceback(tb) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request six.raise_from(e, None) <string>:3: in raise_from ??? /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request httplib_response = conn.getresponse() /usr/lib/python3.10/http/client.py:1374: in getresponse response.begin() /usr/lib/python3.10/http/client.py:318: in begin version, status, reason = self._read_status() /usr/lib/python3.10/http/client.py:287: in _read_status raise RemoteDisconnected("Remote end closed connection without" ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
2. test_group_chat_offline_pn, id: 702808
Test setup failed: /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request six.raise_from(e, None) <string>:3: in raise_from ??? /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request httplib_response = conn.getresponse() /usr/lib/python3.10/http/client.py:1374: in getresponse response.begin() /usr/lib/python3.10/http/client.py:318: in begin version, status, reason = self._read_status() /usr/lib/python3.10/http/client.py:287: in _read_status raise RemoteDisconnected("Remote end closed connection without" E http.client.RemoteDisconnected: Remote end closed connection without response During handling of the above exception, another exception occurred: critical/chats/test_group_chat.py:195: in prepare_devices self.homes[0].just_fyi('Admin creates group chat') ../views/base_view.py:368: in just_fyi self.driver.execute_script("sauce:context=STEP: %s" % some_str) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script return self.execute(command, { /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:319: in execute response = self.command_executor.execute(driver_command, params) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:376: in execute return self._request(command_info[0], url, body=data) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:399: in _request resp = self._conn.request(method, url, body=body, headers=headers) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:78: in request return self.request_encode_body( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:170: in request_encode_body return self.urlopen(method, url, extra_kw) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/poolmanager.py:376: in urlopen response = conn.urlopen(method, u.request_uri, kw) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:787: in urlopen retries = retries.increment( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/util/retry.py:550: in increment raise six.reraise(type(error), error, _stacktrace) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/packages/six.py:769: in reraise raise value.with_traceback(tb) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request six.raise_from(e, None) <string>:3: in raise_from ??? /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request httplib_response = conn.getresponse() /usr/lib/python3.10/http/client.py:1374: in getresponse response.begin() /usr/lib/python3.10/http/client.py:318: in begin version, status, reason = self._read_status() /usr/lib/python3.10/http/client.py:287: in _read_status raise RemoteDisconnected("Remote end closed connection without" ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))
3. test_group_chat_join_send_text_messages_push, id: 702807
Device 3: Could not reach ChatsTab element by pressing back # STEP: Admin creates group chat Test setup failed: /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request six.raise_from(e, None) <string>:3: in raise_from ??? /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request httplib_response = conn.getresponse() /usr/lib/python3.10/http/client.py:1374: in getresponse response.begin() /usr/lib/python3.10/http/client.py:318: in begin version, status, reason = self._read_status() /usr/lib/python3.10/http/client.py:287: in _read_status raise RemoteDisconnected("Remote end closed connection without" E http.client.RemoteDisconnected: Remote end closed connection without response During handling of the above exception, another exception occurred: critical/chats/test_group_chat.py:195: in prepare_devices self.homes[0].just_fyi('Admin creates group chat') ../views/base_view.py:368: in just_fyi self.driver.execute_script("sauce:context=STEP: %s" % some_str) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:634: in execute_script return self.execute(command, { /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:319: in execute response = self.command_executor.execute(driver_command, params) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:376: in execute return self._request(command_info[0], url, body=data) /home/jenkins/.local/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:399: in _request resp = self._conn.request(method, url, body=body, headers=headers) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:78: in request return self.request_encode_body( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/request.py:170: in request_encode_body return self.urlopen(method, url, extra_kw) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/poolmanager.py:376: in urlopen response = conn.urlopen(method, u.request_uri, kw) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:787: in urlopen retries = retries.increment( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/util/retry.py:550: in increment raise six.reraise(type(error), error, _stacktrace) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/packages/six.py:769: in reraise raise value.with_traceback(tb) /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen httplib_response = self._make_request( /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request six.raise_from(e, None) <string>:3: in raise_from ??? /home/jenkins/.local/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request httplib_response = conn.getresponse() /usr/lib/python3.10/http/client.py:1374: in getresponse response.begin() /usr/lib/python3.10/http/client.py:318: in begin version, status, reason = self._read_status() /usr/lib/python3.10/http/client.py:287: in _read_status raise RemoteDisconnected("Remote end closed connection without" ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')) [[blocked by 15859]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_push_emoji, id: 702813
# STEP: Send emoji message to Device 1 while it's on background Device 2: Sending message 'emoji' critical/chats/test_1_1_public_chats.py:1172: in test_1_1_chat_push_emoji chat_2.send_message(emoji.emojize(emoji_message)) ../views/chat_view.py:937: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:117: in wait_for_element raise TimeoutException( Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element [[blocked by 15859]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
# STEP: Device1 goes back online and checks that 1-1 chat will be fetched Device 1: Looking for a message by text: test message `critical/chats/test_1_1_public_chats.py:1306: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:184: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message status was not delivered after back up online, it is "Sending"! E Message was not delivered after resending from offline` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityMultipleDeviceMerged:

1. test_community_mentions_push_notification, id: 702786
Device 1: Tap on found: Button Device 1: Looking for a message by text: user_1 `critical/test_public_chat_browsing.py:759: in test_community_mentions_push_notification self.errors.verify_no_errors() base_test_case.py:184: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Channel did not open by clicking on a notification with the mention for admin` [[blocked by 15859]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_message_send_check_timestamps_sender_username, id: 702838
Device 2: Verifying that 'hello' is under today Device 2: Looking for a message by text: hello critical/test_public_chat_browsing.py:456: in test_community_message_send_check_timestamps_sender_username channel.verify_message_is_under_today_text(message, self.errors) ../views/chat_view.py:927: in verify_message_is_under_today_text message_element.wait_for_visibility_of_element() ../views/base_element.py:135: in wait_for_visibility_of_element raise TimeoutException( Device 2: ChatElementByText by xpath:`//[starts-with(@text,'hello')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']` is not found on the screen after wait_for_visibility_of_element [[blocked by 14797]]* Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (24)

Click to expand

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

use debounce-and-dispatch to improve mention performance

fd78cce

qfrank requested review from ilmotta, cammellos, vkjr, flexsurfer and OmarBasem May 12, 2023 13:29

qfrank self-assigned this May 12, 2023

qfrank requested a review from rasom May 12, 2023 13:48

flexsurfer reviewed May 12, 2023

View reviewed changes

increase time to 400ms

29bba83

ilmotta approved these changes May 12, 2023

View reviewed changes

decrease time to 300ms

c98df10

OmarBasem approved these changes May 15, 2023

View reviewed changes

qfrank added 2 commits May 15, 2023 15:25

update status-go-version.json

abdc385

update status-go-version.json

544e1e1

qfrank merged commit d2e3877 into develop May 15, 2023

qfrank deleted the improvement/mention branch May 15, 2023 07:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use debounce-and-dispatch to improve mention performance #15887

use debounce-and-dispatch to improve mention performance #15887

qfrank commented May 12, 2023 •

edited

Loading

status-im-auto commented May 12, 2023 •

edited

Loading

flexsurfer May 12, 2023

qfrank May 12, 2023 •

edited

Loading

status-im-auto commented May 12, 2023

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

use debounce-and-dispatch to improve mention performance #15887

use debounce-and-dispatch to improve mention performance #15887

Conversation

qfrank commented May 12, 2023 • edited Loading

Summary

Testing notes

Platforms

status-im-auto commented May 12, 2023 • edited Loading

Jenkins Builds

flexsurfer May 12, 2023

Choose a reason for hiding this comment

qfrank May 12, 2023 • edited Loading

Choose a reason for hiding this comment

status-im-auto commented May 12, 2023

77% of end-end tests have passed

Failed tests (7)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

Passed tests (24)

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestCommunityMultipleDeviceMerged:

qfrank commented May 12, 2023 •

edited

Loading

status-im-auto commented May 12, 2023 •

edited

Loading

qfrank May 12, 2023 •

edited

Loading