Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize mention #3479

Merged
merged 2 commits into from
May 15, 2023
Merged

optimize mention #3479

merged 2 commits into from
May 15, 2023

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented May 12, 2023 •
edited
Loading

  • combine api ChatMentionRecheckAtIdxs ChatMentionNewInputTextWithMention into one
  • rename function
  • add some comments for mention api

relate optimization for status-mobile coming soon..

@qfrank qfrank self-assigned this May 12, 2023
@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?
  • Have you tested changes with mobile?
  • Have you tested changes with desktop?

@status-im-auto
Copy link
Member

status-im-auto commented May 12, 2023 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 29af0f2 #1 2023-05-12 10:20:21 ~2 min linux 📦zip
✔️ 29af0f2 #1 2023-05-12 10:22:16 ~4 min ios 📦zip
✔️ 29af0f2 #1 2023-05-12 10:22:56 ~5 min android 📦aar
✖️ 29af0f2 #1 2023-05-12 10:31:34 ~14 min tests 📄log
✖️ 29af0f2 #2 2023-05-12 13:40:13 ~21 min tests 📄log
✔️ 29af0f2 #3 2023-05-12 13:49:38 ~1 min tests 📄log

@OmarBasem
Copy link
Contributor

@qfrank good work!

Did you tryout that commit on status-mobile

@qfrank
Copy link
Contributor Author

qfrank commented May 12, 2023 •
edited
Loading

The corresponding pr for status mobile will be pushed in an hour, it was already done, afk for 1 hour ☺️ @OmarBasem

ilmotta
ilmotta approved these changes May 12, 2023
View reviewed changes
Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great practice to start documenting the public endpoints @qfrank.

@qfrank qfrank mentioned this pull request May 12, 2023
Merged
@qfrank
Copy link
Contributor Author

qfrank commented May 12, 2023 •
edited
Loading

Great practice to start documenting the public endpoints @qfrank.

time to introduce it to desktop team 😉

@qfrank qfrank merged commit 39f486a into develop May 15, 2023
@qfrank qfrank deleted the improvement/mention branch May 15, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmarBasem OmarBasem OmarBasem approved these changes

@rasom rasom rasom approved these changes

@ilmotta ilmotta ilmotta approved these changes

Assignees

@qfrank qfrank

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qfrank @status-im-auto @OmarBasem @ilmotta @rasom