build: add Android x86_64 support to Makefile #6990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sets MOBILE_GOARCH to amd64 when ARCH is x86_64 - Sets ANDROID_CLANG_TARGET to x86_64-linux-android<API>
Member
Jenkins Builds
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #6990 +/- ##
===========================================
+ Coverage 55.13% 59.37% +4.24%
===========================================
Files 820 821 +1
Lines 116624 116626 +2
===========================================
+ Hits 64301 69252 +4951
+ Misses 45535 40253 -5282
- Partials 6788 7121 +333
Flags with carried forward coverage won't be shown. Click here to find out more. |
fbarbu15
approved these changes
Oct 8, 2025
jakubgs
approved these changes
Oct 8, 2025
AYAHASSAN287
pushed a commit
that referenced
this pull request
Oct 20, 2025
- Sets MOBILE_GOARCH to amd64 when ARCH is x86_64 - Sets ANDROID_CLANG_TARGET to x86_64-linux-android<API>
AYAHASSAN287
pushed a commit
that referenced
this pull request
Oct 20, 2025
- Sets MOBILE_GOARCH to amd64 when ARCH is x86_64 - Sets ANDROID_CLANG_TARGET to x86_64-linux-android<API>
romanzac
added a commit
that referenced
this pull request
Nov 14, 2025
* test: First draft for settings wrappers and test file added * test: Making changes in test env & add tests * test: Add new test * feat: improve blockchainstate * feat: replace old transfer detection algorithm with multistandardbalance and transferdetector * build: add Android x86_64 support to Makefile (#6990) - Sets MOBILE_GOARCH to amd64 when ARCH is x86_64 - Sets ANDROID_CLANG_TARGET to x86_64-linux-android<API> * ci: use official base docker image for builds Referenced issue: * status-im/infra-ci#188 * test: community chats (#6987) * test: community chats * test: community chats review * test: Adding node tests * test: contact verification (#6997) * chore: point go.mod to original go-ethereum repo * chore: drop usage of non-multichain ethclient methods in rpc chain client * chore: drop usage of non-multichain ethclient methods in community tokens service * chore: drop usage of non-multichain ethclient methods in fees manager * chore: adapt to new geth logger * chore: remove unused log_parser code * chore: replace custom NoSign parameter from bind.TransactOpts * chore: update SingleRequestCodec to go-ethereum upstream * chore: use `go-waku` with upstream `go-ethereum` (#6978) * chore: upgrade go-waku and go-discover * chore: make vendor * feat: go-waku v0.10.0 * chore: fix tests * chore: bump go-waku and go-discover (#6983) * refactor: use common Migrate function - Use sqlite.Migrate in protocol to remove logic duplication. - Remove legacy ad-hoc migration fix. It is now safe to assume that no users are running versions old enough to require this workaround. * refactor: move pubkeys utils from protocol to crypto package These utils are generic enough to be moved to crypto package. * fix: Crash on uninitialized filterManager Not sure if this will only hide the root cause because the proper flow on pairing is unknown to me. But from what I've seen Waku is only started after login. While `subscribe` and `unsubscribe` is used in the pairing flow as well. * test: Add new tests * test: Adding wrappers &tests * test: Add positive & negative tests * test: Added backup tests * feat: clean up balance fetching from token manager (#6991) * feat: improvemets to multistandardbalance controller * feat: introduce tokenbalances package * chore: replace balance fetching capabilities from reader and token manager with tokenbalances * feat: allow overriding multicall3 contract address * chore: fix tests * chore: pr comments * fix(scripts): branch_version_generated use current base branch (#7007) * fix: goimports configuration (#7004) * fix: goimports only 1 local package * fix: vscode settings goimports * fix: un-gitignore IDEA code styles * feat: goland code styles * fix: remove generate_handlers nolint comment * chore: lint-fix all files * feat: local timesource (#7003) * feat: local timesource * fix: nwaku * fix: rebase issues * feat(benchmark): threads and goroutines count (#7006) * feat: added numThreads to expvars * test: added num of threads and goroutines to benchmarks * fix: issues * chore: cleanup chain client and transactor (#7008) * chore: make rpc.Client implement EthClientGetter * chore: remove unused types * chore: cleanup unused methods and use interface instead of rpc Client * chore: cleanup transactor * chore: move pendingtxtracker to separate package * chore: fix tests * test: add all APIs tests * test: Apply linters * fix: reduce test variants to shorten test durations * fix: lints * fix: remove print statements for debug-only purpose * fix: use logger when necessary * chore: use `go-waku` with upstream `go-ethereum` (#6978) * chore: upgrade go-waku and go-discover * chore: make vendor * feat: go-waku v0.10.0 * chore: bump go-waku and go-discover (#6983) * feat: clean up balance fetching from token manager (#6991) * feat: improvemets to multistandardbalance controller * feat: introduce tokenbalances package * chore: replace balance fetching capabilities from reader and token manager with tokenbalances * feat: allow overriding multicall3 contract address * chore: fix tests * chore: pr comments * fix: rebase on develop - remove unused imports * fix: wait longer for backend in Jenkins * test: look for potential problems beyond failing tests * test: test_check_node_config_params * test: service context behavior * test: revert wakuext service name * fix: test_news_feed_enabled * fix: test_news_notifications_enabled * fix: test_toggle_news_notifications_enabled * fix: test_toggle_news_rss_enabled * fix: test_set_valid_backup_path * fix: wait 40s for backend in Jenkins * fix: remove unused function * fix: test_last_tokens_update_advances_after_updating_token_preferences * test: temporary fix for - test_delete_exemptions_invalid_id * test: temporary fix for - test_notifications_set_global_mentions_rejects_wrong_types_and_preserves_value * test: race condition fix for - test_update_keycard_uid_success * test: return to the original timeout value * fix: remove redundant deepcopy * fix: remove line without effect in - test_full_migrate_flow * fix: change to skip annotation * fix: improve assertions * fix: remove ExemptionsDefaults related code * fix: uncomment - test_notifications_set_group_chats_invalid_values * fix: remove Go code for - NotificationsSetGlobalMentions - DeleteExemptions * fix: commented out tests - test_notifications_set_global_mentions_rejects_wrong_types_and_preserves_value - test_delete_exemptions_invalid_id * fix: naming and test clarity * fix: remove redundant news feed tests * fix: regroup tests * fix: re-run stuck codecov tests --------- Co-authored-by: Dario Gabriel Lipicar <dario@status.im> Co-authored-by: Mag. <50769329+glitchminer@users.noreply.github.com> Co-authored-by: markoburcul <marko@status.im> Co-authored-by: fbarbu15 <florin@status.im> Co-authored-by: Patryk Osmaczko <osmaczkopatryk@gmail.com> Co-authored-by: Igor Sirotin <sirotin@status.im> Co-authored-by: Alex Jbanca <alexjb@status.im> Co-authored-by: Roman <zajic@zajic.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android x86_64 support is required for testing on LambdaTest with virtual devices. This PR:
Closes #6989