-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat_: nwaku in status #5946
Draft
richard-ramos
wants to merge
13
commits into
develop
Choose a base branch
from
feature/nwaku-in-status
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat_: nwaku in status #5946
+6,545
−1,682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (76)
|
richard-ramos
force-pushed
the
feature/nwaku-in-status
branch
2 times, most recently
from
October 17, 2024 22:05
ac519a1
to
498dd95
Compare
richard-ramos
force-pushed
the
feature/nwaku-in-status
branch
2 times, most recently
from
October 18, 2024 15:34
70b1011
to
8198ac1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5946 +/- ##
============================================
- Coverage 13.07% 0.00% -13.08%
============================================
Files 797 797
Lines 107755 107347 -408
============================================
- Hits 14087 0 -14087
- Misses 91867 107347 +15480
+ Partials 1801 0 -1801
Flags with carried forward coverage won't be shown. Click here to find out more.
|
- some minor progress to add nwaku in status-go - nwaku.go: GetNumConnectedPeers controls when passed pubsub is empty - waku_test.go: adapt TestWakuV2Store - add missing shard.go - feat_: build nwaku with nix and use build tags to choose between go-waku and nwaku (#5896) - chore_: update nwaku - nwaku bump (#5911) - bump: nwaku - chore: add USE_NWAKU env flag - fix: build libwaku only if needed - feat: testing discovery and dialing with nwaku integration (#5940)
…esult iterator impl (#5971)
…and libwaku test to run (#5986)
richard-ramos
force-pushed
the
feature/nwaku-in-status
branch
from
October 29, 2024 16:22
38353ca
to
e829dea
Compare
richard-ramos
force-pushed
the
feature/nwaku-in-status
branch
from
October 29, 2024 16:31
e829dea
to
fd9d9f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short summary which serves as a squashed-commit message.
A description to understand introduced changes without reading the code.
Important changes:
Closes #