Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nwaku)_: message publisher and sent verifier #5966

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

richard-ramos
Copy link
Member

Adds the message publisher and verifier implementation that uses nwaku for most of its functionality.
Note that it uses some protobuffers from go-waku. We should probably change this to generate the protobuffers from https://github.com/waku-org/waku-proto instead of using those from go-waku, but this is something that can be done on a separate PR.

@status-im-auto
Copy link
Member

status-im-auto commented Oct 18, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
6cb8047 #1 2024-10-18 20:07:19 ~1 min ios 📄log
6cb8047 #1 2024-10-18 20:07:47 ~2 min android 📄log
✖️ 6cb8047 #1 2024-10-18 20:08:02 ~2 min tests-rpc 📄log
6cb8047 #1 2024-10-18 20:08:06 ~2 min linux 📄log
✖️ 6cb8047 #1 2024-10-18 20:08:53 ~3 min tests 📄log

Copy link

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing, thank you!

Great idea to maintain Config and WakuConfig separate at least for now, that was a huuuuge breaking point I introduced 😬

@richard-ramos richard-ramos merged commit d6079c7 into feature/nwaku-in-status Oct 23, 2024
2 of 7 checks passed
@richard-ramos richard-ramos deleted the nwaku/publisher-verifier branch October 23, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants