Skip to content

Conversation

@noeliaSD
Copy link
Contributor

@noeliaSD noeliaSD commented Nov 26, 2025

Fixes #19062

What does the PR do

This PR introduces several improvements and fixes across the group chat creation and management flows:

  1. fix(GroupChat): Compact layout adjustments using LayoutItemProxy
    Improves the header layout in compact mode by moving the input to a second line and separating the “Save Changes” button. Also refines suggestions popup alignment and width.

  2. feat(GroupChat): Add Flickable + Flow layout with auto-scroll
    Replaces the previous ScrollView with a Flickable + Flow solution supporting dynamic tag wrapping, vertical scrolling, auto-scroll-to-end, and proper cursor visibility.

  3. fix(GroupChats): Correct initial state when switching chats
    Resets root.state on chatContentModuleChanged to prevent the group management option from appearing when navigating between chats.

  4. fix(CreateChat): Prevent clipping in portrait mode
    Adds a conditional left anchor to ensure proper width allocation for CreateChatView in portrait while preserving existing layout behavior in landscape.

Affected areas

  1. Create New Chat flow
  2. Create / Modify Existing Chat - Members management

Architecture compliance

Screencapture of the functionality

GROUP CHAT MANAGEMENT - DESKTOP

Screen.Recording.2025-11-26.at.19.55.43.mov

GROUP CHAT MANAGEMENT - MOBILE
Screenshot 2025-11-26 at 20 47 46

Screenshot 2025-11-26 at 20 48 15

CREATE NEW CHAT - MOBILE LAYOUT

Screenshot 2025-11-26 at 20 49 03

Impact on end user

Better UX on group chats creation and members management in all platforms.

How to test

  1. Create New Chat flow
  2. Create / Modify Existing Chat - Members management

Risk

Regressions in these 2 specific flows

@noeliaSD noeliaSD changed the title fix(GroupChats) - fix(GroupChats) - Enhance Group Chat UI: Compact Layout Fixes, New Flickable Flow, and Navigation/Portrait Bugfixes Nov 26, 2025
@noeliaSD noeliaSD changed the title fix(GroupChats) - Enhance Group Chat UI: Compact Layout Fixes, New Flickable Flow, and Navigation/Portrait Bugfixes Enhance Group Chat UI: Compact Layout Fixes, New Flickable Flow, and Navigation/Portrait Bugfixes Nov 26, 2025
… group chat header

Implemented `LayoutItemProxy` as a solution to improve the layout in compact screens: the input now moves to the second line, and Save Changes is displayed separately from Cancel.

Improved suggestions popup in compact mode: updated x alignment and adjusted width.

A more complete redesign of the group chat header/management UI is planned later.
…sor visibility fixes

Introduces a new Flickable + Flow layout to replace the previous ScrollView structure.

Ensures dynamic wrapping of member tags, vertical scrolling, and automatic scroll-to-end when content grows. Keeps
focus-based auto-positioning.
…agement option

Ensures correct initial state on chat content module change.
Sets `root.state = d.stateInfoButtonContent` so the group management option no longer appears when switching between chats.
@noeliaSD noeliaSD self-assigned this Nov 26, 2025
@status-im-auto
Copy link
Member

status-im-auto commented Nov 26, 2025

Jenkins Builds

Click to see older builds (22)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ebb43b0 #1 2025-11-26 20:04:03 ~7 min tests/nim 📄log
ebb43b0 #1 2025-11-26 20:10:16 ~14 min ios/aarch64 📄log
✔️ ebb43b0 #1 2025-11-26 20:13:36 ~17 min linux/x86_64 📦tgz
✔️ ebb43b0 #1 2025-11-26 20:14:34 ~18 min tests/ui 📄log
✔️ ebb43b0 #1 2025-11-26 20:15:12 ~19 min macos/aarch64 🍎dmg
✔️ ebb43b0 #1 2025-11-26 20:18:34 ~22 min linux/x86_64-nwaku 📦tgz
✔️ ebb43b0 #1 2025-11-26 20:18:49 ~22 min macos/aarch64-nwaku 🍎dmg
✔️ ebb43b0 #1 2025-11-26 20:29:17 ~33 min windows/x86_64 💿exe
✔️ ebb43b0 pr19412 2025-11-26 20:39:47 ~26 min tests/e2e 📊rpt
✖️ ebb43b0 PR19412 2025-11-26 21:00:42 ~31 min tests/e2e-windows 📊rpt
✔️ c5fcc8a2 #1 2025-11-26 20:05:47 ~9 min android/arm64 🤖apk 📲
✔️ fc4e675 #2 2025-11-26 20:42:53 ~7 min tests/nim 📄log
✔️ fc4e675 #2 2025-11-26 20:44:46 ~9 min android/arm64 🤖apk 📲
fc4e675 #2 2025-11-26 20:48:25 ~12 min macos/aarch64-nwaku 📄log
✔️ fc4e675 #2 2025-11-26 20:49:11 ~13 min macos/aarch64 🍎dmg
✔️ fc4e675 #2 2025-11-26 20:49:56 ~14 min tests/ui 📄log
✔️ fc4e675 #2 2025-11-26 20:52:25 ~16 min linux/x86_64-nwaku 📦tgz
✔️ fc4e675 #2 2025-11-26 20:52:27 ~16 min ios/aarch64 📱ipa
✔️ fc4e675 #2 2025-11-26 20:53:45 ~18 min linux/x86_64 📦tgz
✔️ fc4e675 #2 2025-11-26 21:06:03 ~30 min windows/x86_64 💿exe
✔️ fc4e675 pr19412 2025-11-26 21:09:06 ~15 min tests/e2e 📊rpt
✖️ fc4e675 PR19412 2025-11-26 21:30:19 ~24 min tests/e2e-windows 📊rpt
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ ea49b36 #3 2025-11-27 09:43:20 ~6 min tests/nim 📄log
ea49b36 #3 2025-11-27 09:47:55 ~11 min ios/aarch64 📄log
✔️ ea49b36 #3 2025-11-27 09:50:11 ~13 min macos/aarch64 🍎dmg
✔️ ea49b36 #3 2025-11-27 09:50:29 ~13 min tests/ui 📄log
✔️ ea49b36 #3 2025-11-27 09:52:41 ~15 min linux/x86_64 📦tgz
✔️ ea49b36 #3 2025-11-27 09:53:05 ~16 min linux/x86_64-nwaku 📦tgz
ea49b36 #4 2025-11-27 09:58:17 ~8 min ios/aarch64 📄log
✔️ ea49b36 #3 2025-11-27 10:01:22 ~24 min windows/x86_64 💿exe
✔️ ea49b36 #4 2025-11-27 10:03:08 ~26 min macos/aarch64-nwaku 🍎dmg
✔️ ea49b36 pr19412 2025-11-27 10:12:01 ~19 min tests/e2e 📊rpt
✔️ ea49b36 #5 2025-11-27 10:12:34 ~12 min ios/aarch64 📱ipa
✖️ ea49b36 PR19412 2025-11-27 10:27:54 ~26 min tests/e2e-windows 📊rpt
✔️ 150f076e #3 2025-11-27 09:46:12 ~9 min android/arm64 🤖apk 📲

@noeliaSD noeliaSD marked this pull request as ready for review November 26, 2025 20:35
@noeliaSD noeliaSD requested review from a team, alexjba, caybro and micieslak as code owners November 26, 2025 20:35
@noeliaSD noeliaSD requested review from Khushboo-dev-cpp and jrainville and removed request for a team November 26, 2025 20:35
Copy link
Member

@jrainville jrainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@micieslak micieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Desktop and Androild. Looks nice! I like the new approach with Flow :)

Applies a conditional left anchor to the `CreateChatView` loader to ensure proper width allocation in portrait mode.

Prevents the view from being cut off on the left while keeping the previous layout behavior in landscape.

Fixes #19062
@noeliaSD noeliaSD merged commit 2cb0e6a into master Nov 27, 2025
12 of 13 checks passed
@noeliaSD noeliaSD deleted the fix/issue-19063 branch November 27, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Group Chat] Group chat creation UI has clipped elements (left corner)

4 participants