-
Notifications
You must be signed in to change notification settings - Fork 90
Enhance Group Chat UI: Compact Layout Fixes, New Flickable Flow, and Navigation/Portrait Bugfixes #19412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… group chat header Implemented `LayoutItemProxy` as a solution to improve the layout in compact screens: the input now moves to the second line, and Save Changes is displayed separately from Cancel. Improved suggestions popup in compact mode: updated x alignment and adjusted width. A more complete redesign of the group chat header/management UI is planned later.
…sor visibility fixes Introduces a new Flickable + Flow layout to replace the previous ScrollView structure. Ensures dynamic wrapping of member tags, vertical scrolling, and automatic scroll-to-end when content grows. Keeps focus-based auto-positioning.
…agement option Ensures correct initial state on chat content module change. Sets `root.state = d.stateInfoButtonContent` so the group management option no longer appears when switching between chats.
Member
Jenkins BuildsClick to see older builds (22)
|
ebb43b0 to
fc4e675
Compare
jrainville
approved these changes
Nov 26, 2025
Member
jrainville
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
micieslak
approved these changes
Nov 27, 2025
Member
micieslak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Desktop and Androild. Looks nice! I like the new approach with Flow :)
Applies a conditional left anchor to the `CreateChatView` loader to ensure proper width allocation in portrait mode. Prevents the view from being cut off on the left while keeping the previous layout behavior in landscape. Fixes #19062
fc4e675 to
ea49b36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19062
What does the PR do
This PR introduces several improvements and fixes across the group chat creation and management flows:
fix(GroupChat): Compact layout adjustments using
LayoutItemProxyImproves the header layout in compact mode by moving the input to a second line and separating the “Save Changes” button. Also refines suggestions popup alignment and width.
feat(GroupChat): Add Flickable + Flow layout with auto-scroll
Replaces the previous ScrollView with a Flickable + Flow solution supporting dynamic tag wrapping, vertical scrolling, auto-scroll-to-end, and proper cursor visibility.
fix(GroupChats): Correct initial state when switching chats
Resets
root.stateonchatContentModuleChangedto prevent the group management option from appearing when navigating between chats.fix(CreateChat): Prevent clipping in portrait mode
Adds a conditional left anchor to ensure proper width allocation for
CreateChatViewin portrait while preserving existing layout behavior in landscape.Affected areas
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
GROUP CHAT MANAGEMENT - DESKTOP
Screen.Recording.2025-11-26.at.19.55.43.mov
GROUP CHAT MANAGEMENT - MOBILE

CREATE NEW CHAT - MOBILE LAYOUT
Impact on end user
Better UX on group chats creation and members management in all platforms.
How to test
Risk
Regressions in these 2 specific flows