feat: activities in a browser wallet #19405
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkjr
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
Member
Jenkins BuildsClick to see older builds (71)
|
vkjr
force-pushed
the
feat/browser-account-activity
branch
from
9474a38 to
856b50e
Compare
vkjr
changed the title
vkjr
force-pushed
the
feat/browser-account-activity
branch
from
856b50e to
cd18b9b
Compare
vkjr
changed the title
vkjr
force-pushed
the
feat/browser-account-activity
branch
2 times, most recently
from
c9d8cb9 to
c672022
Compare
fix: comments fixed
vkjr
force-pushed
the
feat/browser-account-activity
branch
from
c672022 to
b4cd6e8
Compare
caybro
reviewed
Nov 28, 2025
Member
caybro
left a comment
caybro
left a comment
There was a problem hiding this comment.
Nice work overall, a bit unsure about the overall architecture, esp. regarding the stores
storybook/stubs/AppLayouts/Browser/stores/BrowserActivityStore.qml
Outdated
Show resolved
Hide resolved
| import StatusQ.Core.Theme | ||
| import StatusQ.Core.Utils as SQUtils | ||
|
|
||
| import SortFilterProxyModel |
| readonly property bool isLightTheme: Theme.palette.name === Constants.lightThemeName | ||
| property color animatedBgColor | ||
| property int txType: walletRootStore.getTransactionType(root.modelData) | ||
| property int txType: activityStore.getTransactionType(root.modelData) |
Member
There was a problem hiding this comment.
Suggested change
| property int txType: activityStore.getTransactionType(root.modelData) | |
| readonly property int txType: activityStore.getTransactionType(root.modelData) |
| } | ||
|
|
||
| function getDappDetails(chainId, contractAddress) { | ||
| return undefined |
micieslak
reviewed
Nov 28, 2025
Member
There was a problem hiding this comment.
The general, currently used approach is to mock stores, it's our cut-off line between ui and nim side.
For details please refer to: https://github.com/status-im/status-desktop/blob/master/guidelines/QML_ARCHITECTURE_GUIDE.md
Contributor
Author
@caybro, could you please elaborate? |
Contributor
Author
|
@caybro, @micieslak - please take a look again, review notes fixed. |
caybro
reviewed
Dec 3, 2025
| overview: root.browserWalletStore.dappBrowserAccount | ||
| communitiesStore: null | ||
| currencyStore: SharedStores.CurrenciesStore {} | ||
| networksStore: SharedStores.NetworksStore {} |
Member
There was a problem hiding this comment.
These 2 stores are global, ie you should not recreate them but pass them down all the way from AppMain
|
|
||
| readonly property string selectedAddress: browserWalletStore.dappBrowserAccount.address | ||
| readonly property bool isNonArchivalNode: false | ||
| readonly property bool showAllAccounts: false |
noeliaSD
reviewed
Dec 3, 2025
|
|
||
| // TODO: https://github.com/status-im/status-desktop/issues/15329 | ||
| // Get DApp data from the backend | ||
| function getDappDetails(chainId, contractAddress) { |
Contributor
There was a problem hiding this comment.
Wondering if it would make sense to have a specific Utils file for this context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Implements activities list in a browser wallet.
Affected areas
browser_section/module.nimBrowserActivityStore.qmladded for reusingHistoryView.qmlandTransactionDelegate.qmlHistoryView.qmlandTransactionDelegate.qmlpropertywalletRootStorewas renamed toactivityStore, removed wallet-specific importsArchitecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality