fix: getDappDetails moved to Utils.qml for reusability

Author: vkjr

ui/app/AppLayouts/Browser/stores/BrowserActivityStore.qml

@@ -68,7 +68,7 @@ QtObject {
     }
 
     function getDappDetails(chainId, contractAddress) {
-        return undefined
+        return Utils.getDappDetails(chainId, contractAddress)
     }
 
     function isOwnedAccount(address) {

ui/app/AppLayouts/Wallet/stores/RootStore.qml

@@ -463,29 +463,8 @@ QtObject {
         return address1.toUpperCase() === address2.toUpperCase()
     }
 
-    // TODO: https://github.com/status-im/status-desktop/issues/15329
-    // Get DApp data from the backend
     function getDappDetails(chainId, contractAddress) {
-        switch (contractAddress) {
-            case Constants.swap.paraswapV5ApproveContractAddress:
-            case Constants.swap.paraswapV5SwapContractAddress:
-                return {
-                    "icon": Theme.png("swap/%1".arg(Constants.swap.paraswapIcon)),
-                    "url": Constants.swap.paraswapHostname,
-                    "name": Constants.swap.paraswapName,
-                    "approvalContractAddress": Constants.swap.paraswapV5ApproveContractAddress,
-                    "swapContractAddress": Constants.swap.paraswapV5SwapContractAddress,
-                }
-            case Constants.swap.paraswapV6_2ContractAddress:
-                return {
-                    "icon": Theme.png("swap/%1".arg(Constants.swap.paraswapIcon)),
-                    "url": Constants.swap.paraswapUrl,
-                    "name": Constants.swap.paraswapName,
-                    "approvalContractAddress": Constants.swap.paraswapV6_2ContractAddress,
-                    "swapContractAddress": Constants.swap.paraswapV6_2ContractAddress,
-                }
-        }
-        return undefined
+        return Utils.getDappDetails(chainId, contractAddress)
     }
 
     function resetActivityData() {

ui/imports/shared/controls/TransactionDelegate.qml

@@ -212,7 +212,7 @@ StatusListItem {
 
         readonly property bool isLightTheme: Theme.palette.name === Constants.lightThemeName
         property color animatedBgColor
-        property int txType: activityStore.getTransactionType(root.modelData)
+        readonly property int txType: activityStore.getTransactionType(root.modelData)
 
         readonly property var secondIconAsset: StatusAssetSettings {
             width: root.tokenIconAsset.width

ui/imports/utils/Utils.qml

@@ -861,6 +861,31 @@ QtObject {
         return nativeTokenRawToDecimal(chainID, rawGasPrice)
     }
 
+    // TODO: https://github.com/status-im/status-desktop/issues/15329
+    // Get DApp data from the backend
+    function getDappDetails(chainId, contractAddress) {
+        switch (contractAddress) {
+            case Constants.swap.paraswapV5ApproveContractAddress:
+            case Constants.swap.paraswapV5SwapContractAddress:
+                return {
+                    "icon": Theme.png("swap/%1".arg(Constants.swap.paraswapIcon)),
+                    "url": Constants.swap.paraswapHostname,
+                    "name": Constants.swap.paraswapName,
+                    "approvalContractAddress": Constants.swap.paraswapV5ApproveContractAddress,
+                    "swapContractAddress": Constants.swap.paraswapV5SwapContractAddress,
+                }
+            case Constants.swap.paraswapV6_2ContractAddress:
+                return {
+                    "icon": Theme.png("swap/%1".arg(Constants.swap.paraswapIcon)),
+                    "url": Constants.swap.paraswapUrl,
+                    "name": Constants.swap.paraswapName,
+                    "approvalContractAddress": Constants.swap.paraswapV6_2ContractAddress,
+                    "swapContractAddress": Constants.swap.paraswapV6_2ContractAddress,
+                }
+        }
+        return undefined
+    }
+
     // Leave this function at the bottom of the file as QT Creator messes up the code color after this
     function isPunct(c) {
         return /(!|\@|#|\$|%|\^|&|\*|\(|\)|\+|\||-|=|\\|{|}|[|]|"|;|'|<|>|\?|,|\.|\/)/.test(c)