fix(ci): replace gitParameter with string parameter #19234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
approved these changes
Nov 7, 2025
Member
Jenkins BuildsClick to see older builds (19)
|
caybro
approved these changes
Nov 7, 2025
jakubgs
force-pushed
the
ci/drop-git-paramater
branch
2 times, most recently
from
7cc7ade to
30ac3c2
Compare
Recent upgrade of Jenkins and Git Paramter plugin caused these to appear: [2025-11-07T12:07:08.487Z] Scheduling project: status-desktop » e2e » prs Invalid parameter value: (StringParameterValue) GIT_REF='6e42ff2a5cb10933332d6722e1c19babc9973c07' Which are caused by recently patched vulnerability in the plugin: https://www.jenkins.io/security/advisory/2025-07-09/#SECURITY-3419 https://github.com/jenkinsci/git-parameter-plugin/releases/tag/444.vca_b_84d3703c2 We could disable this check with: gitParameterDefinition.allowAnyParameterValue=true But just using a String paramater is simpler and more convenient. Signed-off-by: Jakub Sokołowski <jakub@status.im>
jakubgs
force-pushed
the
ci/drop-git-paramater
branch
from
30ac3c2 to
5fbadab
Compare
Member
Author
|
Keep in mind feature branches will have to rebase to take effect. |
Contributor
I've rebased by branch, but the error is the same https://ci.status.im/blue/organizations/jenkins/status-desktop%2Fprs%2Fwindows%2Fx86_64%2Fpackage/detail/PR-19116/7/pipeline git log: |
Contributor
|
Using |
Member
Author
|
That change doesn't make sense. We want to test an exact commit, not the branch. But it works as a temp fix to let it run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent upgrade of Jenkins and Git Paramter plugin caused these to appear:
Which are caused by recently patched vulnerability in the plugin:
We could disable this check with:
But just using a String paramater is simpler and more convenient.