ci: add Jenkinsfile and config for e2e mobile tests #19163
+829
−296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (51)
|
jakubgs
requested changes
Nov 7, 2025
Base automatically changed from
e2e_appium/add-browserstack-tests
to
e2e_appium/add-browserstack
November 7, 2025 13:36
glitchminer
force-pushed
the
e2e_appium/add-browserstack
branch
from
42e0569 to
220c950
Compare
- wallet locators - app lifecycle management - toast message handling (visibility checks and logging). - saved addresses page
…ertions - Replaced instances of LambdaTest reporting with Cloud reporting - Assertion messages for clarity - Updated test methods for toast handling
glitchminer
force-pushed
the
ci/test-e2e-mobile
branch
from
162d5a5 to
a21a910
Compare
jakubgs
requested changes
Nov 27, 2025
Member
jakubgs
left a comment
jakubgs
left a comment
There was a problem hiding this comment.
Much better, but needs some more work. You make a few weird assumptions about availability of env variables.
Comment on lines
+16
to
+24
| if [[ ! -f "${APK_PATH}" ]]; then | ||
| echo "Error: APK_PATH does not exist or is not a file: ${APK_PATH}" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [[ ! -r "${APK_PATH}" ]]; then | ||
| echo "Error: APK_PATH is not readable: ${APK_PATH}" >&2 | ||
| exit 1 | ||
| fi |
Member
There was a problem hiding this comment.
Pointless double test, the -r will fail if -f would fail.
Comment on lines
+11
to
+14
| if [[ -z "${APK_PATH:-}" ]]; then | ||
| echo "Error: APK_PATH environment variable is required" >&2 | ||
| exit 1 | ||
| fi |
Member
There was a problem hiding this comment.
Why is this an env variables rather than a positional argument?
| curl -s -u "${BROWSERSTACK_USERNAME}:${BROWSERSTACK_ACCESS_KEY}" \ | ||
| -X POST "https://api-cloud.browserstack.com/app-automate/upload" \ | ||
| -F "file=@${APK_PATH}" \ | ||
| -F "custom_id=${CUSTOM_ID}" |
Member
There was a problem hiding this comment.
Use --show-error and --fail-with-body to make debugging less painful:
Suggested change
| -F "custom_id=${CUSTOM_ID}" | |
| curl --request POST "https://api-cloud.browserstack.com/app-automate/upload" | |
| --silent --show-error --fail-with-body \ | |
| --user "${BROWSERSTACK_USERNAME}:${BROWSERSTACK_ACCESS_KEY}" \ | |
| --form "file=@${APK_PATH}" \ | |
| --form "custom_id=${CUSTOM_ID}" |
And use full flag names instead of cryptic one letter flags. Those are for CLI use, not for scripts.
| } | ||
|
|
||
| parameters { | ||
| gitParameter( |
Member
There was a problem hiding this comment.
Avoid using gitParameter, see this PR for problem description:
Comment on lines
+91
to
+101
| stage('Use provided BrowserStack app') { | ||
| when { | ||
| expression { params.BROWSERSTACK_APP_ID?.trim() } | ||
| } | ||
| steps { | ||
| script { | ||
| env.BROWSERSTACK_APP_ID = params.BROWSERSTACK_APP_ID.trim() | ||
| echo "Using provided BrowserStack app id: ${env.BROWSERSTACK_APP_ID}" | ||
| } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Pointless stage that achieves nothing.
| steps { | ||
| script { | ||
| dir('test/e2e_appium') { | ||
| println("Using TEST_DEVICE_ID: ${env.TEST_DEVICE_ID}") |
Member
There was a problem hiding this comment.
Not sure what the point of this is since user can just look up job parameters.
| stage('Publish test results') { | ||
| steps { | ||
| script { | ||
| def runId = env.E2E_RUN_ID?.trim() |
Member
There was a problem hiding this comment.
Where is this supposed to come from?
| def runId = env.E2E_RUN_ID?.trim() | ||
| def reportsPattern = runId ? "test/e2e_appium/reports/${runId}/**/*.xml" : "test/e2e_appium/reports/**/*.xml" | ||
| junit allowEmptyResults: true, testResults: reportsPattern | ||
| def archivePattern = runId ? "test/e2e_appium/reports/${runId}/**/*" : "test/e2e_appium/reports/**/*" |
Member
There was a problem hiding this comment.
Why is this pattern wider than the one above? How are those artifacts useful?
Comment on lines
+224
to
+233
| success { | ||
| script { | ||
| github.notifyPR(true) | ||
| } | ||
| } | ||
| failure { | ||
| script { | ||
| github.notifyPR(false) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| success { | |
| script { | |
| github.notifyPR(true) | |
| } | |
| } | |
| failure { | |
| script { | |
| github.notifyPR(false) | |
| } | |
| } | |
| success { script { github.notifyPR(true) } } | |
| failure { script { github.notifyPR(false) } } |
| } | ||
| } | ||
| cleanup { | ||
| cleanWs(disableDeferredWipeout: true) |
Member
There was a problem hiding this comment.
Suggested change
| cleanWs(disableDeferredWipeout: true) | |
| cleanWs(disableDeferredWipeout: true) | |
| dir(env.WORKSPACE_TMP) { deleteDir() } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
ci/Jenkinsfile.test-e2e.androidso Jenkins can run Android smoke tests on BrowserStack (in preparation for PR checks and nightly runs)Successfully ran with simulated config locally but still to be tested from Jenkins directly