Skip to content

[6.x] Fix Firefox not receiving text selection in nested Bards #14021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonvarga merged 2 commits into from
Feb 24, 2026
+15 −8
Merged

[6.x] Fix Firefox not receiving text selection in nested Bards #14021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c584e6e
Fix Firefox not receiving text selection inside elements with a dragg…
jaygeorge Feb 20, 2026
67277e0
Remove part of the Firefox fix.
jaygeorge Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions resources/js/components/fieldtypes/bard/Image.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,11 +213,5 @@ export default {
this.closeEditor();
},
},
updated() {
// This is a workaround to avoid Firefox's inability to select inputs/textareas when the
// parent element is set to draggable: https://bugzilla.mozilla.org/show_bug.cgi?id=739071
this.$el.setAttribute('draggable', false);
},
};
</script>
17 changes: 15 additions & 2 deletions resources/js/components/fieldtypes/bard/Set.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,12 +330,25 @@ export default {
);

reveal.mount(this.$refs.container, this.expand);

// Firefox bug 739071: text selection doesn't work inside elements with a
// draggable ancestor. ProseMirror sets draggable=true on the node-view-wrapper
// because the Set node spec has draggable:true. We must keep it false.
this.$el.setAttribute('draggable', false);
this._draggableObserver = new MutationObserver(() => {
if (this.$el.getAttribute('draggable') !== 'false') {
this.$el.setAttribute('draggable', false);
}
});
this._draggableObserver.observe(this.$el, { attributes: true, attributeFilter: ['draggable'] });
},

updated() {
// This is a workaround to avoid Firefox's inability to select inputs/textareas when the
// parent element is set to draggable: https://bugzilla.mozilla.org/show_bug.cgi?id=739071
this.$el.setAttribute('draggable', false);
},
Comment on lines 346 to 348
Copy link
Member

@jasonvarga jasonvarga Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the setAttribute in updated is redundant now?


beforeUnmount() {
this._draggableObserver?.disconnect();
},
};
</script>