[6.x] Fix Firefox not receiving text selection in nested Bards#14021
Open
[6.x] Fix Firefox not receiving text selection in nested Bards#14021
Conversation
…able ancestor Co-authored-by: Cursor <cursoragent@cursor.com>
jasonvarga
requested changes
Feb 20, 2026
Comment on lines
346
to
348
| updated() { | ||
| // This is a workaround to avoid Firefox's inability to select inputs/textareas when the | ||
| // parent element is set to draggable: https://bugzilla.mozilla.org/show_bug.cgi?id=739071 | ||
| this.$el.setAttribute('draggable', false); | ||
| }, |
Member
There was a problem hiding this comment.
I think the setAttribute in updated is redundant now?
The old code was a Firefox workaround that cleared draggable on the root so inputs inside the node could be focused. If the editor (e.g. TipTap) now only makes the element with data-drag-handle draggable and no longer marks the root as draggable, that workaround is redundant.
Contributor
Author
|
Ah yes, Claude seems to think it's OK to remove that too. I re-tested the fix in Firefox and it still works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Problem
As per #13852, In Firefox, clicking inside a Bard field that is nested within another Bard field (e.g. Bard > Replicator > Bard) doesn't work properly. You cannot single-click to place the cursor or double-click to select a word. Triple-clicking to select a paragraph does work.
This is caused by Firefox bug 739071 (opened 13 years ago, WOW) — text selection doesn't work inside elements that have an ancestor with
draggable=true. ProseMirror setsdraggable=trueon the Bard Set's node-view-wrapper element during initialization because the Set node spec hasdraggable: true. The existing workaround in theupdated()hook resets this tofalse, but only on Vue re-renders — ProseMirror can set it back at any time in between.What this PR Does
MutationObserverin the Bard Set component'smounted()hook that watches thedraggableattribute on the node-view-wrapper and immediately resets it tofalsewhenever ProseMirror changes it. This ensuresdraggablenever staystruelong enough for Firefox's bug to prevent text selection in nested editors.How to Reproduce