Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup tweaks #4304

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Setup tweaks #4304

merged 1 commit into from
Nov 28, 2023

Conversation

DingDongSoLong4
Copy link
Collaborator

Two tweaks to the initial setup process:

  • When a config file is specified on the command line or using STASH_CONFIG_FILE, the final confirmation screen now correctly shows paths relative to the config file location - previously they'd just show as relative to /. I missed this in Improved/fixed macOS support #4153.
  • Overridden paths (ie with an environment variable) are now hidden from the final confirmation screen. Even though you aren't able to set values for overridden paths, they'd previously still show in the final screen with deceptive values, as shown in the screenshot below.

Both of the following were run using STASH_CACHE=/tmp ./stash -c stash/config.yml.

Before:
image
Now:
image

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Nov 28, 2023
@WithoutPants WithoutPants added this to the Version 0.24.0 milestone Nov 28, 2023
@WithoutPants WithoutPants merged commit fc1fc20 into stashapp:develop Nov 28, 2023
2 checks passed
@DingDongSoLong4 DingDongSoLong4 deleted the setup-tweaks branch November 28, 2023 06:43
halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants