-
-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved/fixed macOS support #4153
Improved/fixed macOS support #4153
Conversation
I've just come across #2284, but for me on macOS Ventura 13.5.2 Stash is able to create and find the config file in Edit: I misread that issue, and I can reproduce it now. The problem is caused by App Translocation, which runs the app from a random temporary directory, making it basically impossible to figure out where the binary is located. The only solution will have to be disabling using current working directory for setup when running the |
Fantastic that someone who can figure out MacOS is looking at this. Did you figure out how to reduce the executable size with the unified app? When I last tried this, the frontend assets were included twice, so the Mac binary was nearly twice the size of the other platforms. |
Ah I hadn't thought of size, but I have no idea how, or if it is even possible, to deduplicate data in a unified binary. It makes sense that it would be twice the size (and it indeed is), since it basically contains two separate binaries. The only real thing that could be deduplicated is the UI assets, as you mention, which are currently 7.8MB. The entire macOS unified binary is 85MB, so that's a potential ~10% decrease, which isn't that much imo. The alternative is to do what we're doing now and keep the two macOS binaries separate, but I think the convenience of the unified binary is worth the size tradeoff to most users. And PS I don't actually know that much about macOS apps/development, I just have a MacBook so I'm able to test things - all of the fixes here came from trial, error and Google :) |
85 MB is definitely not catastrophic and I wouldn't let that hinder this. |
023b0a2
to
46906e5
Compare
I've added some tweaks/improvements to the Makefile:
There's also now a new I've also removed And then I've updated various documentation files, to reflect these changes and remove outdated information. |
* Fix macOS notifications * Change CFBundleIdentifier to match domain * Distribute Stash.app * Also build universal phasher binary * Fix binary name in check_version.go * Expose GOOS, working dir and home dir in systemStatus endpoint * Disable setup in working directory when running Stash.app * More Makefile improvements, remove unused scripts * Improve READMEs and documentation
This improves macOS support:
gosx-notifier
(Replace Link with Open and Activate kermieisinthehouse/gosx-notifier#1). This was because the-sender
flag was not being used.stash-macos
binary, rather than separate binaries.Stash.app
, allowing macOS users to completely avoid the Terminal.stashapp.cc
.