Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview scrubber #4022

Merged
merged 7 commits into from
Aug 24, 2023
Merged

Conversation

WithoutPants
Copy link
Collaborator

@WithoutPants WithoutPants commented Aug 12, 2023

Adds a hoverable control on the bottom edge of the scene preview to allow scrubbing through the scene, using the scene sprite image:

chrome_QytgLb4DVH

TODO - portrait videos are not currently displaying correctly

@WithoutPants WithoutPants added the feature Pull requests that add a new feature label Aug 12, 2023
@WithoutPants
Copy link
Collaborator Author

Updated to show timestamp, changed styling around a bit, and changed the click behaviour to navigate to the timestamp when the scrubber is clicked. Also fixed the scaling issues on portrait scenes.

chrome_tD3m4siqXp

@WithoutPants WithoutPants changed the title [WIP] Preview scrubber Preview scrubber Aug 14, 2023
@WithoutPants WithoutPants added this to the Version 0.23.0 milestone Aug 17, 2023
@WithoutPants WithoutPants merged commit 3dc01a9 into stashapp:develop Aug 24, 2023
2 checks passed
@TamalesEnMiPinata
Copy link

Very nice feature!

@IAmKontrast
Copy link

Great feature, I'll love it!
Unfortunately the scene sprite image resolution and details are poor especially for higher resolution scenes. This means mouseover video looks awesome but using the new preview scrubber looks terrible. You can see it perfectly in the video example of @WithoutPants on August 14.

My first thought: Configurable resolution for generating scene scrupper images

@DogmaDragon DogmaDragon linked an issue Aug 20, 2024 that may be closed by this pull request
halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
* Add sprite info hook
* Remove axios dependency
* Add preview scrubber
* Add scrubber timestamp
* On click go to timestamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Allow for scrubbing of videos on hover in the grid view
3 participants