Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Hovering scene cover in tagger view without generated previews #4190

Open
xantror opened this issue Oct 10, 2023 · 0 comments
Open
Labels
bug report Bug reports that are not yet verified

Comments

@xantror
Copy link

xantror commented Oct 10, 2023

Describe the bug
When hovering on a scene cover in tagger view, it "blanks" the cover image when preview is not generated.

To Reproduce
Steps to reproduce the behavior:

  1. Go to scene tagger
  2. Hover on the scene cover for a scene where preview is not generated
  3. Image goes blank

404 message appears in console, although this is also the case for grid view when preview does not exist:
HTTP load failed with status 404. Load of media resource <scheme>://<stash-url>/scene/<scene-id>/preview failed.

Expected behavior
Expect hovering on the cover in tagger view to have the same behavior as grid view: hovering on the image should not "blank" the image if preview for that scene is not generated.

Screenshots

38457238905728345

Stash Version: v0.23.0 (eca2f9b)

Desktop:

  • OS: Windows 11 (22H2)
  • Browser: Firefox (118.0.1)

Additional context
I think that either some logic needs to be put in place to disable trying to load preview if it is not generated or at minimum handle it like in grid view where the cover image does not get "blanked".

Would also be nice if #4022 could be integrated into tagger view.

@xantror xantror added the bug report Bug reports that are not yet verified label Oct 10, 2023
@WithoutPants WithoutPants added this to the Version 0.25.0 milestone Feb 9, 2024
@WithoutPants WithoutPants removed this from the Version 0.25.0 milestone Feb 13, 2024
@github-project-automation github-project-automation bot moved this to To triage in Bug fixing Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug reports that are not yet verified
Projects
Status: To triage
Development

No branches or pull requests

2 participants