Skip to content

feat(starknet_os): os_logger: implement OsLogger::exit_tx #5284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_tx branch from 5cf69a7 to 09545d8 Compare March 25, 2025 20:19
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_exit_tx branch from 34507d5 to 7b1f67e Compare March 25, 2025 20:19
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_tx branch from 09545d8 to 7edd85c Compare March 25, 2025 20:29
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_exit_tx branch from 7b1f67e to 49b7b8f Compare March 25, 2025 20:29
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_tx branch from 7edd85c to 6a70f8f Compare March 25, 2025 21:07
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_exit_tx branch from 49b7b8f to 0b0dbd2 Compare March 25, 2025 21:07
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review March 25, 2025 21:07
@dorimedini-starkware dorimedini-starkware self-assigned this Mar 25, 2025
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_tx branch from 6a70f8f to 040fd61 Compare March 26, 2025 10:07
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_exit_tx branch from 0b0dbd2 to bb489cc Compare March 26, 2025 10:07
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_tx branch from 040fd61 to 06a1a46 Compare March 26, 2025 11:55
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_exit_tx branch from bb489cc to 86d2f92 Compare March 26, 2025 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_tx branch from 06a1a46 to bccbf40 Compare March 26, 2025 12:11
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_exit_tx branch from 86d2f92 to b71bc21 Compare March 26, 2025 12:12
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_tx branch from bccbf40 to 7e98732 Compare March 26, 2025 12:46
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_exit_tx branch from b71bc21 to ca84f13 Compare March 26, 2025 12:47
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_tx branch from 7e98732 to 8c5e100 Compare March 26, 2025 14:37
@dorimedini-starkware dorimedini-starkware changed the base branch from 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_tx to main March 26, 2025 15:11
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_exit_tx branch from ca84f13 to 58e6e1c Compare March 26, 2025 15:14
Copy link

graphite-app bot commented Mar 26, 2025

Merge activity

  • Mar 26, 11:14 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit d3c8362 Mar 26, 2025
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants