Skip to content

feat(starknet_os): os_logger: implement OsLogger::enter_syscall #5281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2025
Merged

feat(starknet_os): os_logger: implement OsLogger::enter_syscall #5281

merged 1 commit into from
Mar 26, 2025

Conversation

dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

This was referenced Mar 25, 2025
Merged
Merged
Merged
Merged
Merged
@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Mar 25, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dorimedini-starkware dorimedini-starkware self-assigned this Mar 25, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review March 25, 2025 17:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

Artifacts upload workflows:

@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_resourcecounter_sub_counter branch from c4b8c52 to 634aa49 Compare March 25, 2025 19:39
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_syscall branch from c5f1ecb to ecdaab0 Compare March 25, 2025 19:39
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_resourcecounter_sub_counter branch from 634aa49 to 6d03242 Compare March 25, 2025 20:13
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_syscall branch from ecdaab0 to de3b008 Compare March 25, 2025 20:14
This was referenced Mar 25, 2025
Merged
Merged
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_syscall branch 2 times, most recently from e30e632 to a9a3382 Compare March 25, 2025 21:07
meship-starkware
meship-starkware approved these changes Mar 26, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_resourcecounter_sub_counter branch from 6d03242 to 5db7838 Compare March 26, 2025 10:07
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_syscall branch from a9a3382 to 3618623 Compare March 26, 2025 10:07
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_resourcecounter_sub_counter branch from 5db7838 to dd92b32 Compare March 26, 2025 11:55
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_syscall branch from 3618623 to 3dca312 Compare March 26, 2025 11:55
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_resourcecounter_sub_counter branch from dd92b32 to 0c7a6ad Compare March 26, 2025 12:11
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_syscall branch from 3dca312 to 009cd28 Compare March 26, 2025 12:11
meship-starkware
meship-starkware approved these changes Mar 26, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware)

crates/blockifier/src/execution/deprecated_syscalls/mod.rs line 90 at r2 (raw file):

}

impl DeprecatedSyscallSelector {

Outside of this PR scope. Why is this called deprecated? It contains all syscalls selectors, and some are cairo1 only.

Code quote:

DeprecatedSyscallSelector

dorimedini-starkware
dorimedini-starkware commented Mar 26, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

crates/blockifier/src/execution/deprecated_syscalls/mod.rs line 90 at r2 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Outside of this PR scope. Why is this called deprecated? It contains all syscalls selectors, and some are cairo1 only.

no idea. also no idea why this exists

@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_resourcecounter_sub_counter branch 2 times, most recently from 5218dce to 6a3a42e Compare March 26, 2025 12:46
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_syscall branch from 009cd28 to b347294 Compare March 26, 2025 12:46
meship-starkware
meship-starkware approved these changes Mar 26, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware changed the base branch from 03-25-feat_starknet_os_os_logger_implement_resourcecounter_sub_counter to main March 26, 2025 13:19
@dorimedini-starkware dorimedini-starkware force-pushed the 03-25-feat_starknet_os_os_logger_implement_oslogger_enter_syscall branch from b347294 to e03f24c Compare March 26, 2025 13:21
@graphite-app Graphite App
Copy link

graphite-app bot commented Mar 26, 2025

Merge activity

  • Mar 26, 9:22 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Mar 26, 2025
Merged via the queue into main with commit edc6998 Mar 26, 2025
16 checks passed
idan-starkware pushed a commit that referenced this pull request Mar 26, 2025
@dorimedini-starkware @idan-starkware
feat(starknet_os): os_logger: implement OsLogger::enter_syscall (#5281)
9b58cf9
@idan-starkware idan-starkware mentioned this pull request Mar 26, 2025
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meship-starkware meship-starkware meship-starkware approved these changes

@Yoni-Starkware Yoni-Starkware Awaiting requested review from Yoni-Starkware

Assignees

@dorimedini-starkware dorimedini-starkware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dorimedini-starkware @reviewable-StarkWare @meship-starkware