test(starknet_integration_tests): assert the full blocks flow #5229
Conversation
|
This change is |
Graphite Automations"Yair - Auto-assign" took an action on this PR • (03/24/25)1 assignee was added to this PR based on Yair's automation. |
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @dafnamatsry)
crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 152 at r1 (raw file):
} else { assert_eq!(full_blocks_metric, 0); }
consider extracting into a function.
Code quote:
let metrics = recorder.handle().render();
let full_blocks_metric =
starknet_batcher::metrics::FULL_BLOCKS.parse_numeric_metric::<u64>(&metrics).unwrap();
if expecting_full_blocks {
assert!(full_blocks_metric > 0);
} else {
assert_eq!(full_blocks_metric, 0);
}
yair-starkware
force-pushed
the
yair/e2e_full_blocks
branch
from
9b88a87 to
6af1147
Compare
yair-starkware
force-pushed
the
yair/full_block_metric
branch
from
5a38200 to
1543682
Compare
yair-starkware
force-pushed
the
yair/e2e_full_blocks
branch
from
6af1147 to
1774719
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @alonh5, @dafnamatsry, and @Yael-Starkware)
crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 152 at r1 (raw file):
Previously, Yael-Starkware (YaelD) wrote…
consider extracting into a function.
Done.
yair-starkware
force-pushed
the
yair/e2e_full_blocks
branch
from
1774719 to
a53f68a
Compare
yair-starkware
force-pushed
the
yair/full_block_metric
branch
from
1543682 to
8708926
Compare
yair-starkware
force-pushed
the
yair/e2e_full_blocks
branch
from
a53f68a to
ac260d5
Compare
yair-starkware
force-pushed
the
yair/full_block_metric
branch
from
8708926 to
e891dde
Compare
yair-starkware
force-pushed
the
yair/e2e_full_blocks
branch
from
ac260d5 to
3b4f4e1
Compare
yair-starkware
force-pushed
the
yair/full_block_metric
branch
from
e891dde to
250bc63
Compare
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dafnamatsry and @Yael-Starkware)
crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 49 at r3 (raw file):
false )] // TODO(yair): Add check that a block closed due to being full instead of deadline.
remove
Code quote:
// TODO(yair): Add check that a block closed due to being full instead of deadline.
yair-starkware
force-pushed
the
yair/e2e_full_blocks
branch
from
3b4f4e1 to
f78d347
Compare
yair-starkware
force-pushed
the
yair/full_block_metric
branch
from
250bc63 to
976b6c6
Compare
yair-starkware
force-pushed
the
yair/e2e_full_blocks
branch
from
f78d347 to
a24ee9f
Compare
yair-starkware
force-pushed
the
yair/full_block_metric
branch
from
976b6c6 to
14c10ac
Compare
yair-starkware
force-pushed
the
yair/e2e_full_blocks
branch
from
a24ee9f to
b74930e
Compare
There was a problem hiding this comment.
Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @alonh5, @dafnamatsry, and @Yael-Starkware)
crates/starknet_integration_tests/tests/end_to_end_flow_test.rs line 49 at r3 (raw file):
Previously, alonh5 (Alon Haramati) wrote…
remove
Done.
yair-starkware
force-pushed
the
yair/e2e_full_blocks
branch
from
b74930e to
0625365
Compare
yair-starkware
force-pushed
the
yair/full_block_metric
branch
from
14c10ac to
9f37c2b
Compare
There was a problem hiding this comment.
Reviewed 1 of 3 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5 and @dafnamatsry)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r4, 4 of 4 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dafnamatsry)
No description provided.