feat(starknet_integration_tests): struct to collect batched txs

[yair-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[yair-starkware]

• feat(starknet_integration_tests): refactor e2e flow test #4787 : 2 dependent PRs (#5164 , #5223 )
• feat(starknet_integration_tests): struct to collect batched txs #4786 👈 (View in Graphite)
• feat(starknet_integration_tests): struct to collect streamed txs #4785
• refactor(starknet_integration_tests): copy listen_to_broadcasted_messages to test setup #4784
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Graphite Automations

"Yair - Auto-assign" took an action on this PR • (03/10/25)

1 assignee was added to this PR based on Yair's automation.

[alonh5]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @Yael-Starkware)

---

crates/starknet_integration_tests/src/flow_test_setup.rs line 348 at r1 (raw file):

    while let Some((Ok(message), _)) = broadcasted_messages_receiver.next().await {
        if message.stream_id.0 == expected_height.0 {

Why remove the validation of the message streams?

[Yael-Starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArniStarkware and @yair-starkware)

---

crates/starknet_integration_tests/src/flow_test_setup.rs line 357 at r1 (raw file):

            {
                break;
            }

Is it guaranteed that all messages will come from the same stream, meaning they will have the same stream_id?
Isn't it possible for messages from different streams to be received interleaved?

Code quote:

            if message.message == papyrus_protobuf::consensus::StreamMessageBody::Fin {
                last_message_id = message.message_id;
            }
            // Check that we got the Fin message and all previous messages.
            if last_message_id > 0
                && (0..=last_message_id).all(|id| messages_cache.contains_key(&id))
            {
                break;
            }

[yair-starkware]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @alonh5, @ArniStarkware, and @Yael-Starkware)

---

crates/starknet_integration_tests/src/flow_test_setup.rs line 348 at r1 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Why remove the validation of the message streams?

It is validated in validate_coherent_height_and_round

---

crates/starknet_integration_tests/src/flow_test_setup.rs line 357 at r1 (raw file):

Previously, Yael-Starkware (YaelD) wrote…

Is it guaranteed that all messages will come from the same stream, meaning they will have the same stream_id?
Isn't it possible for messages from different streams to be received interleaved?

It is checked later:

assert_eq!(stream_id, first_stream_id, "Expected the same stream id for all messages");

[alonh5]

Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware and @Yael-Starkware)

---

crates/starknet_integration_tests/src/flow_test_setup.rs line 348 at r1 (raw file):

Previously, yair-starkware (Yair) wrote…

It is validated in validate_coherent_height_and_round

Right, thanks

[Yael-Starkware]

Reviewed 1 of 1 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[alonh5]

Reviewed 1 of 1 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[alonh5]

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)