feat(blockifier): exclude l1_data_gas from accounts in VC

[nimrod-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-03-23T14:21:03Z
• Started at 2025-03-25T07:38:18Z
• Started at 2025-03-25T07:51:59Z
• Started at 2025-03-25T11:18:25Z
• Started at 2025-03-25T11:22:53Z
• Started at 2025-03-25T11:30:27Z
• Started at 2025-03-25T11:31:18Z
• Started at 2025-03-25T15:31:13Z
• Started at 2025-03-26T07:26:02Z
• Started at 2025-03-26T08:06:39Z

[nimrod-starkware]

• feat(blockifier): exclude data gas in cairo native syscall handler #5273
• feat(blockifier): exclude l1_data_gas from accounts in VC #5185 👈 (View in Graphite)
• feat(blockifier): add data gas accounts to VC #5154
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Yoni-Starkware]

Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

---

crates/blockifier/src/execution/syscalls/hint_processor.rs line 473 at r1 (raw file):

        if returned_version != original_version {
            return self.allocate_execution_info_segment(vm, returned_version, exclude_l1_data_gas);
        }

You have to do something like this. The ptr in this syscall is cached, and you must override it if the syscall us called from one of the whitelisted contracts

Code quote:

        if returned_version != original_version {
            return self.allocate_execution_info_segment(vm, returned_version, exclude_l1_data_gas);
        }

[Yoni-Starkware]

Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @nimrod-starkware)

---

crates/blockifier/src/execution/syscalls/syscall_base.rs line 216 at r1 (raw file):

    }

    /// Return wether the class is in the data gas accounts set.

Suggestion:

/// Return whether the L1 data gas should be excluded for the `get_execution_info` syscall.

---

crates/blockifier/src/execution/syscalls/syscall_base.rs line 217 at r1 (raw file):

    /// Return wether the class is in the data gas accounts set.
    pub fn exclude_l1_data_gas(&self) -> bool {

Suggestion:

pub fn should_exclude_l1_data_gas(&self) -> bool 

[nimrod-starkware]

Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @nimrod-starkware and @Yoni-Starkware)

---

crates/blockifier/src/execution/syscalls/hint_processor.rs line 473 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

You have to do something like this. The ptr in this syscall is cached, and you must override it if the syscall us called from one of the whitelisted contracts

What do you think of something like this pseudo-code

If class hash in data gas accounts or in v1 bounds accounts:
    recalculate the execution info ptr
else:
    use the cached one if exists (otherwise calculate and cache)

---

crates/blockifier/src/execution/syscalls/syscall_base.rs line 216 at r1 (raw file):

    }

    /// Return wether the class is in the data gas accounts set.

Done.

---

crates/blockifier/src/execution/syscalls/syscall_base.rs line 217 at r1 (raw file):

    /// Return wether the class is in the data gas accounts set.
    pub fn exclude_l1_data_gas(&self) -> bool {

Done.

[nimrod-starkware]

Reviewable status: 0 of 4 files reviewed, 3 unresolved discussions (waiting on @nimrod-starkware and @Yoni-Starkware)

---

crates/blockifier/src/execution/syscalls/hint_processor.rs line 473 at r1 (raw file):

Previously, nimrod-starkware wrote…

What do you think of something like this pseudo-code

If class hash in data gas accounts or in v1 bounds accounts:
    recalculate the execution info ptr
else:
    use the cached one if exists (otherwise calculate and cache)

Done, i think

[Yoni-Starkware]

What about Native? different PR?

Reviewed 1 of 3 files at r1, 1 of 2 files at r3.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)

---

crates/blockifier/src/execution/syscalls/hint_processor.rs line 471 at r1 (raw file):

        // If the transaction version was overridden, `self.execution_info_ptr` cannot be used.
        if returned_version != original_version {

Hmmm, this code is not necessary. I'll clean it in a different PR.

[nimrod-starkware]

I'll do native in a future PR (on top of this)

Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @nimrod-starkware)

[nimrod-starkware]

Done:
https://reviewable.io/reviews/starkware-libs/sequencer/5273

Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @nimrod-starkware)

[Yoni-Starkware]

Reviewed 1 of 2 files at r4.
Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware)

---

crates/blockifier/src/execution/syscalls/syscall_tests/get_execution_info.rs line 378 at r4 (raw file):

        ],
        (_, _) => {
            vec![felt!(if exclude_l1_data_gas { 2_u8 } else { 3 })] // Length of resource bounds array.

Be consistent

Code quote:

2_u8 } else { 3

---

crates/blockifier/src/execution/syscalls/hint_processor.rs line 668 at r4 (raw file):

                        vm,
                        context,
                        self.base.should_exclude_l1_data_gas(),

Extract into a var and add a comment above: See the comment about the returned version.

Code quote:

self.base.should_exclude_l1_data_gas(),

[nimrod-starkware]

Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @Yoni-Starkware)

---

crates/blockifier/src/execution/syscalls/syscall_tests/get_execution_info.rs line 378 at r4 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Be consistent

Done.

[Yoni-Starkware]

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)