feat(blockifier): add data gas accounts to VC #5154
Conversation
|
This change is |
There was a problem hiding this comment.
Python side:
https://reviewable.io/reviews/starkware-industries/starkware/37403
Reviewable status: 0 of 11 files reviewed, all discussions resolved (waiting on @nimrod-starkware)
nimrod-starkware
force-pushed
the
nimrod/data_gas_accounts/add_to_vc
branch
2 times, most recently
from
c7e36d1 to
762f180
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
nimrod-starkware
force-pushed
the
nimrod/data_gas_accounts/add_to_vc
branch
2 times, most recently
from
be513b8 to
d8b6bb5
Compare
There was a problem hiding this comment.
Reviewed 10 of 11 files at r2, all commit messages.
Reviewable status: 10 of 11 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware)
crates/blockifier/resources/blockifier_versioned_constants_0_13_5.json line 146 at r2 (raw file):
"0x00816dd0297efc55dc1e7559020a3a825e81ef734b558f03c83325d4da7e6253", "0x041bf1e71792aecb9df3e9d04e1540091c5e13122a731e02bec588f71dc1a5c3" ]
Should be empty here
Code quote:
"data_gas_accounts": [
"0x02c8c7e6fbcfb3e8e15a46648e8914c6aa1fc506fc1e7fb3d1e19630716174bc",
"0x00816dd0297efc55dc1e7559020a3a825e81ef734b558f03c83325d4da7e6253",
"0x041bf1e71792aecb9df3e9d04e1540091c5e13122a731e02bec588f71dc1a5c3"
]
nimrod-starkware
force-pushed
the
nimrod/data_gas_accounts/add_to_vc
branch
from
d8b6bb5 to
565bf41
Compare
There was a problem hiding this comment.
Reviewable status: 1 of 11 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @Yoni-Starkware)
crates/blockifier/resources/blockifier_versioned_constants_0_13_5.json line 146 at r2 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Should be empty here
Done.
nimrod-starkware
force-pushed
the
nimrod/data_gas_accounts/add_to_vc
branch
from
565bf41 to
b9e6c91
Compare
nimrod-starkware
force-pushed
the
nimrod/data_gas_accounts/add_to_vc
branch
from
b9e6c91 to
6396d4c
Compare
There was a problem hiding this comment.
Reviewed 10 of 10 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @nimrod-starkware)
No description provided.