feat(starknet_os): implement write_split_result

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• feat(starknet_os): implement write_split_result #5163 👈 (View in Graphite)
• chore(starknet_os): move write_split_result #5162
• feat(starknet_os): integrate the split function #5161
• feat(starknet_os): convert BigUints from decimal strings only once #5127
• feat(starknet_os): use ark_poly FFT implementation #4985
• feat(starknet_os): inline ark_poly bit_reversal algorithm #5110
• test(starknet_os): fft regression #4984
• feat(starknet_os): use BigUint instead of BigInt in KZG area #4922
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[aner-starkware]

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @amosStarkware)

---

crates/starknet_os/src/hints/hint_implementation/kzg/implementation.rs line 87 at r1 (raw file):

    let value =
        get_integer_from_var_name(Ids::Value.into(), vm, ids_data, ap_tracking)?.to_bigint();
    let res_ptr = get_relocatable_from_var_name(Ids::Res.into(), vm, ids_data, ap_tracking)?;

Aren't you supposed to use @nimrod-starkware 's function here?
IIUC, it's supposed to be ids.res.address_; is this equivalent?

Code quote:

let res_ptr = get_relocatable_from_var_name(Ids::Res.into(), vm, ids_data, ap_tracking)?;

[dorimedini-starkware]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @aner-starkware)

---

crates/starknet_os/src/hints/hint_implementation/kzg/implementation.rs line 87 at r1 (raw file):

Previously, aner-starkware wrote…

Aren't you supposed to use @nimrod-starkware 's function here?
IIUC, it's supposed to be ids.res.address_; is this equivalent?

the x.address_ field is the address of x, so no need for nimrod's nested-field function: write_arg should be equivalent. taken from moonsong implementation, no need for any offset computation

[aner-starkware]

Reviewed 1 of 3 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

[aner-starkware]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

[aner-starkware]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

[aner-starkware]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

[aner-starkware]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

[dorimedini-starkware]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

[aner-starkware]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)

[graphite-app]

Merge activity

• Mar 26, 9:30 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

[dorimedini-starkware]

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)