chore(starknet_os): move write_split_result #5162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Mar 23, 2025
This was referenced Mar 23, 2025
dorimedini-starkware
force-pushed
the
03-23-feat_starknet_os_integrate_the_split_function
branch
from
76f91ed to
f6f495a
Compare
dorimedini-starkware
force-pushed
the
03-23-chore_starknet_os_move_write_split_result
branch
from
63d9062 to
62007a5
Compare
dorimedini-starkware
force-pushed
the
03-23-feat_starknet_os_integrate_the_split_function
branch
from
f6f495a to
488ae74
Compare
dorimedini-starkware
force-pushed
the
03-23-chore_starknet_os_move_write_split_result
branch
from
62007a5 to
70c050b
Compare
dorimedini-starkware
force-pushed
the
03-23-feat_starknet_os_integrate_the_split_function
branch
from
488ae74 to
373e57b
Compare
dorimedini-starkware
force-pushed
the
03-23-chore_starknet_os_move_write_split_result
branch
from
70c050b to
2cab525
Compare
aner-starkware
approved these changes
Mar 23, 2025
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @amosStarkware)
dorimedini-starkware
force-pushed
the
03-23-feat_starknet_os_integrate_the_split_function
branch
from
373e57b to
fcb53e0
Compare
dorimedini-starkware
force-pushed
the
03-23-chore_starknet_os_move_write_split_result
branch
from
2cab525 to
90f3373
Compare
aner-starkware
approved these changes
Mar 23, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
dorimedini-starkware
force-pushed
the
03-23-feat_starknet_os_integrate_the_split_function
branch
from
fcb53e0 to
0d12f7e
Compare
dorimedini-starkware
force-pushed
the
03-23-chore_starknet_os_move_write_split_result
branch
from
90f3373 to
3d2a704
Compare
dorimedini-starkware
force-pushed
the
03-23-feat_starknet_os_integrate_the_split_function
branch
from
0d12f7e to
20fb8b2
Compare
dorimedini-starkware
force-pushed
the
03-23-chore_starknet_os_move_write_split_result
branch
from
3d2a704 to
02f6a83
Compare
dorimedini-starkware
force-pushed
the
03-23-feat_starknet_os_integrate_the_split_function
branch
from
20fb8b2 to
a01814d
Compare
dorimedini-starkware
force-pushed
the
03-23-chore_starknet_os_move_write_split_result
branch
from
02f6a83 to
6c8fc0c
Compare
dorimedini-starkware
force-pushed
the
03-23-feat_starknet_os_integrate_the_split_function
branch
from
a01814d to
d165e45
Compare
dorimedini-starkware
force-pushed
the
03-23-chore_starknet_os_move_write_split_result
branch
from
6c8fc0c to
80ee16b
Compare
dorimedini-starkware
force-pushed
the
03-23-feat_starknet_os_integrate_the_split_function
branch
from
d165e45 to
0dfa4c9
Compare
dorimedini-starkware
force-pushed
the
03-23-chore_starknet_os_move_write_split_result
branch
from
80ee16b to
a29dfa0
Compare
Signed-off-by: Dori Medini <dori@starkware.co>
dorimedini-starkware
force-pushed
the
03-23-feat_starknet_os_integrate_the_split_function
branch
from
0dfa4c9 to
de9e590
Compare
dorimedini-starkware
force-pushed
the
03-23-chore_starknet_os_move_write_split_result
branch
from
a29dfa0 to
b0a369b
Compare
dorimedini-starkware
changed the base branch from
03-23-feat_starknet_os_integrate_the_split_function
to
main
idan-starkware
pushed a commit
that referenced
this pull request
Mar 26, 2025
* feat(starknet_os): integrate the split function * refactor(starknet_os): split to bigint3 Signed-off-by: Dori Medini <dori@starkware.co> * chore(starknet_os): move write_split_result --------- Signed-off-by: Dori Medini <dori@starkware.co>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.