feat(apollo_mempool): add transaction queue to snapshot

[lev-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[lev-starkware]

• feat(apollo_mempool): add MempoolState to snapshot #5135
• feat(apollo_mempool): add transaction queue to snapshot #5129 👈 (View in Graphite)
• feat(apollo_monitoring_endpoint): add getting mempool snapshot from the monitoring #5088
• chore(apollo_proc_macros): fixing dev_dependencies #5191
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-03-20T16:40:17Z
• Started at 2025-03-23T16:22:47Z
• Started at 2025-03-23T16:38:26Z
• Started at 2025-03-23T18:21:41Z
• Started at 2025-03-23T19:16:01Z
• Started at 2025-03-27T12:57:24Z
• Started at 2025-03-30T06:58:23Z
• Started at 2025-03-31T08:22:11Z
• Started at 2025-03-31T09:02:16Z
• Started at 2025-03-31T10:19:40Z
• Started at 2025-03-31T10:24:50Z
• Started at 2025-03-31T15:09:58Z
• Started at 2025-04-01T08:11:27Z

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.368 ms 34.414 ms 34.463 ms]
change: [-1.8081% -1.6358% -1.4635%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.666 ms 34.701 ms 34.745 ms]
change: [-4.1234% -2.5069% -1.0777%] (p = 0.00 < 0.05)
Performance has improved.
Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

[alonh5]

Reviewed 2 of 6 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @lev-starkware)

---

crates/starknet_monitoring_endpoint/src/monitoring_endpoint_test.rs line 131 at r2 (raw file):

}

fn create_mempool_snapshot() -> MempoolSnapshot {

Suggestion:

expected_mempool_snapshot()

---

crates/starknet_monitoring_endpoint/src/monitoring_endpoint_test.rs line 146 at r2 (raw file):

fn return_mempool_snapshot() -> MempoolClientResult<MempoolSnapshot> {
    Ok(create_mempool_snapshot())
}

Is this function still needed?

Code quote:

fn return_mempool_snapshot() -> MempoolClientResult<MempoolSnapshot> {
    Ok(create_mempool_snapshot())
}

---

crates/starknet_monitoring_endpoint/src/monitoring_endpoint_test.rs line 154 at r2 (raw file):

fn create_json_from_mempool_snapshot(snapshot: &MempoolSnapshot) -> Value {
    to_value(snapshot).expect("Failed to serialize MempoolSnapshot")
}

Do you think these one line functions are needed?

Code quote:

fn create_json_from_string(json_str: &str) -> Value {
    from_str(json_str).expect("Failed to parse JSON string")
}

fn create_json_from_mempool_snapshot(snapshot: &MempoolSnapshot) -> Value {
    to_value(snapshot).expect("Failed to serialize MempoolSnapshot")
}

---

crates/starknet_monitoring_endpoint/src/monitoring_endpoint_test.rs line 163 at r2 (raw file):

    assert_eq!(response.status(), StatusCode::OK);
    let body_bytes = hyper::body::to_bytes(response.into_body()).await.unwrap();
    let body_string = String::from_utf8(body_bytes.to_vec()).unwrap();

Use serde_json::from_slice instead of going through String.

Code quote:

let body_string = String::from_utf8(body_bytes.to_vec()).unwrap();

---

crates/starknet_mempool/src/mempool.rs line 597 at r2 (raw file):

        Ok(MempoolSnapshot {
            transactions: self.tx_pool.get_chronological_txs_hashes(),
            transaction_queue: self.tx_queue.get_queue_snapshot(),

Convention in rust is not to use the get prefix in getters.

Suggestion:

            transactions: self.tx_pool.chronological_txs_hashes(),
            transaction_queue: self.tx_queue.queue_snapshot(),

[lev-starkware]

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @alonh5)

---

crates/starknet_mempool/src/mempool.rs line 597 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Convention in rust is not to use the get prefix in getters.

Done.

---

crates/starknet_monitoring_endpoint/src/monitoring_endpoint_test.rs line 146 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Is this function still needed?

Done.

---

crates/starknet_monitoring_endpoint/src/monitoring_endpoint_test.rs line 154 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Do you think these one line functions are needed?

Done.

---

crates/starknet_monitoring_endpoint/src/monitoring_endpoint_test.rs line 163 at r2 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Use serde_json::from_slice instead of going through String.

Done.

---

crates/starknet_monitoring_endpoint/src/monitoring_endpoint_test.rs line 131 at r2 (raw file):

}

fn create_mempool_snapshot() -> MempoolSnapshot {

Done.

[alonh5]

Reviewed 14 of 14 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lev-starkware)

---

crates/apollo_mempool/src/communication.rs line 104 at r3 (raw file):

    }

    fn get_mempool_snapshot(&self) -> MempoolResult<MempoolSnapshot> {

Suggestion:

mempool_snapshot

[lev-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/apollo_mempool/src/communication.rs line 104 at r3 (raw file):

    }

    fn get_mempool_snapshot(&self) -> MempoolResult<MempoolSnapshot> {

Done.

[alonh5]

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

[graphite-app]

Merge activity

• Apr 1, 4:11 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

[lev-starkware]

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)