feat(apollo_monitoring_endpoint): add getting mempool snapshot from the monitoring

[lev-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-03-19T15:36:49Z
• Started at 2025-03-19T15:59:08Z
• Started at 2025-03-19T16:36:27Z
• Started at 2025-03-19T16:50:31Z
• Started at 2025-03-19T16:54:47Z
• Started at 2025-03-20T08:47:07Z
• Started at 2025-03-20T08:47:20Z
• Started at 2025-03-20T14:31:34Z
• Started at 2025-03-20T16:40:17Z
• Started at 2025-03-23T16:22:50Z
• Started at 2025-03-23T18:21:47Z
• Started at 2025-03-23T18:41:36Z
• Started at 2025-03-27T12:57:24Z
• Started at 2025-03-30T06:58:23Z
• Started at 2025-03-30T06:58:23Z
• Started at 2025-03-31T08:22:11Z
• Started at 2025-03-31T09:02:16Z
• Started at 2025-03-31T10:19:20Z
• Started at 2025-03-31T10:24:49Z
• Started at 2025-03-31T15:09:58Z

[lev-starkware]

• feat(apollo_mempool): add MempoolState to snapshot #5135
• feat(apollo_mempool): add transaction queue to snapshot #5129
• feat(apollo_monitoring_endpoint): add getting mempool snapshot from the monitoring #5088 👈 (View in Graphite)
• chore(apollo_proc_macros): fixing dev_dependencies #5191
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[alonh5]

Reviewed 2 of 4 files at r3, 1 of 3 files at r4, 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lev-starkware)

---

crates/starknet_monitoring_endpoint/src/monitoring_endpoint.rs line 136 at r5 (raw file):

// Returns Mempool snapshot
async fn mempool_snapshot(

Please insrument this function and also error log the error returned from the mempool client.

---

crates/starknet_sequencer_node/src/components.rs line 184 at r5 (raw file):

    let monitoring_endpoint = match config.components.monitoring_endpoint.execution_mode {
        ActiveComponentExecutionMode::Enabled => {
            let mempool_client = if mempool.is_some() {

Does this mean it will work only if the monitoring server and the mempool are in the same pod?

[github-actions]

Benchmark movements:
full_committer_flow performance improved 😺
full_committer_flow time: [30.510 ms 30.549 ms 30.590 ms]
change: [-2.4918% -1.8295% -1.3132%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild

[lev-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @alonh5)

---

crates/starknet_monitoring_endpoint/src/monitoring_endpoint.rs line 136 at r5 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Please insrument this function and also error log the error returned from the mempool client.

Done.

---

crates/starknet_sequencer_node/src/components.rs line 184 at r5 (raw file):

Previously, alonh5 (Alon Haramati) wrote…

Does this mean it will work only if the monitoring server and the mempool are in the same pod?

We have a monitoring endpoint in every pod. So we could always obtain the mempool dump.

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.120 ms 35.603 ms 36.176 ms]
change: [+1.4200% +2.8597% +4.4914%] (p = 0.00 < 0.05)
Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
4 (4.00%) high mild
8 (8.00%) high severe

[alonh5]

Reviewed 9 of 9 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)

[lev-starkware]

Reviewed 1 of 1 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @lev-starkware)