Skip to content

chore(starknet_sequencer_node): create component configs in deployment #5093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Itay-Tsabary-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

Itay-Tsabary-Starkware commented Mar 19, 2025

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-18-chore_starknet_sequencer_node_create_component_configs_in_deployment_split branch from 0af942e to 25e4385 Compare March 19, 2025 20:12
Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


crates/starknet_sequencer_node/src/deployment.rs line 177 at r1 (raw file):

                        _ => panic!("Unexpected service name"),
                    }
                }

This can be slightly simplified by creating a all_inner_service_names() fn for DistributedNodeServiceName.
Will do so in a different pr.

Code quote:

                for service_name in service_names {
                    match service_name {
                        ServiceName::DistributedNode(inner_service_name) => {
                            component_config_pair_map
                                .insert(inner_service_name, inner_service_name.into());
                        }
                        _ => panic!("Unexpected service name"),
                    }
                }

Copy link
Collaborator

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-18-chore_starknet_sequencer_node_create_component_configs_in_deployment_split branch from 25e4385 to d935312 Compare March 20, 2025 07:41
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-18-chore_starknet_sequencer_node_create_component_configs_in_deployment branch from 44c500d to 65e63f2 Compare March 20, 2025 07:41
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from 03-18-chore_starknet_sequencer_node_create_component_configs_in_deployment to main March 20, 2025 08:20
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 03-18-chore_starknet_sequencer_node_create_component_configs_in_deployment_split branch from d935312 to fd1c663 Compare March 20, 2025 08:52
Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware added this pull request to the merge queue Mar 20, 2025
Merged via the queue into main with commit 5a43368 Mar 20, 2025
9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants