-
Notifications
You must be signed in to change notification settings - Fork 58
chore(starknet_sequencer_node): create component configs in deployment #5093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(starknet_sequencer_node): create component configs in deployment #5093
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0af942e
to
25e4385
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion
crates/starknet_sequencer_node/src/deployment.rs
line 177 at r1 (raw file):
_ => panic!("Unexpected service name"), } }
This can be slightly simplified by creating a all_inner_service_names()
fn for DistributedNodeServiceName
.
Will do so in a different pr.
Code quote:
for service_name in service_names {
match service_name {
ServiceName::DistributedNode(inner_service_name) => {
component_config_pair_map
.insert(inner_service_name, inner_service_name.into());
}
_ => panic!("Unexpected service name"),
}
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
25e4385
to
d935312
Compare
44c500d
to
65e63f2
Compare
d935312
to
fd1c663
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
No description provided.