refactor(starknet_client): share code in tests mocks

[ayeletstarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ayeletstarkware]

• test(starknet_client): deprecated feeder gw block block_unserializable #5087
• test(starknet_client): deprecated feeder gw get_block_not_found #5084
• test(starknet_client): deprecated feeder gw get_block #5083
• test(starknet_client): deprecated feeder gw get_latest_block_when_no_blocks_exists #5082
• test(starknet_client): deprecated feeder gw get_latest_block_when_blocks_exists #5079
• refactor(starknet_client): share code in tests mocks #5074 👈 (View in Graphite)
• refactor(starknet_client): share test code, block not found #5062
• refactor(starknet_client): share get_block_url test code #5034
• refactor(starknet_client): split test, for better readability #5026
• refactor(starknet_client): remove fee market info from json files #5019
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[graphite-app]

Merge activity

• Mar 20, 4:05 AM EDT: Graphite rebased this pull request after merging its parent, because this pull request is set to merge when ready.

[yair-starkware]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @alonh5)

---

crates/starknet_client/src/reader/starknet_feeder_gateway_client_test.rs line 75 at r1 (raw file):

}

// TODO(Ayelet): Remove support for the old feeder gateway after upgrading to version 0.14.0.

Move the TODO to be before the use_deprecated_feeder_gateway arg

Code quote:

// TODO(Ayelet): Remove support for the old feeder gateway after upgrading to version 0.14.0.

---

crates/starknet_client/src/reader/starknet_feeder_gateway_client_test.rs line 76 at r1 (raw file):

// TODO(Ayelet): Remove support for the old feeder gateway after upgrading to version 0.14.0.
// Consider making this function generic for all successful mock responses in this file.

This is a separate TODO, right?

Code quote:

// Consider making this function generic for all successful mock responses in this file.

---

crates/starknet_client/src/reader/starknet_feeder_gateway_client_test.rs line 88 at r1 (raw file):

}

// TODO(Ayelet): Remove support for the old feeder gateway after upgrading to version 0.14.0.

Same

Code quote:

// TODO(Ayelet): Remove support for the old feeder gateway after upgrading to version 0.14.0.

[ayeletstarkware]

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @alonh5 and @yair-starkware)

---

crates/starknet_client/src/reader/starknet_feeder_gateway_client_test.rs line 75 at r1 (raw file):

Previously, yair-starkware (Yair) wrote…

Move the TODO to be before the use_deprecated_feeder_gateway arg

Already there. removed from here.

---

crates/starknet_client/src/reader/starknet_feeder_gateway_client_test.rs line 76 at r1 (raw file):

Previously, yair-starkware (Yair) wrote…

This is a separate TODO, right?

yes

---

crates/starknet_client/src/reader/starknet_feeder_gateway_client_test.rs line 88 at r1 (raw file):

Previously, yair-starkware (Yair) wrote…

Same

Done.

[yair-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

[yair-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)