refactor(starknet_client): share test code, block not found #5062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Mar 19, 2025
alonh5
approved these changes
Mar 19, 2025
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)
ayeletstarkware
force-pushed
the
ayelet/starknet-client/share-get-block-url-code
branch
2 times, most recently
from
7eacb71 to
1c02ed0
Compare
ayeletstarkware
force-pushed
the
ayelet/starknet-client/share-code-block-not-found
branch
from
f310cc6 to
6bd25c0
Compare
ayeletstarkware
force-pushed
the
ayelet/starknet-client/share-get-block-url-code
branch
from
1c02ed0 to
d4fd0bb
Compare
ayeletstarkware
force-pushed
the
ayelet/starknet-client/share-code-block-not-found
branch
from
6bd25c0 to
b83eafd
Compare
This was referenced Mar 19, 2025
ayeletstarkware
changed the base branch from
ayelet/starknet-client/share-get-block-url-code
to
main
ayeletstarkware
force-pushed
the
ayelet/starknet-client/share-code-block-not-found
branch
from
b83eafd to
6a7bd9e
Compare
Merge activity
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.